Only admin can generate rewards non collaboratively #160
Assignees
Comments
|
Don't you have to be an admin to set price and time priority. |
|
/start |
Tip
|
Any collaborator can set a label
This is unclear but throw an error when the author closes the issue, and they are not an admin/billing_manager We should also check that a collaborator approved the pull review. If so then we can make an exception and generate rewards |
I chose to just not generate a permit if the issue author and assignee are the same and issue the author himself as closed the issue as completed (the issue author also set the pricing labels) |
|
/help |
1 similar comment
|
/help |
Available Commands
|
|
Note The following contributors may be suitable for this task: rndquu
|
+ Evaluating results. Please wait... |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task | 1 | 75 |
| Issue | Comment | 1 | 1.95 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Don't you have to be an admin to set price and time priority.Al… | 2.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 46
wordValue: 0.1
result: 2.59
| 1 | 3 | 1.95 |
[ 75 WXDAI ]
@0x4007
⚠️ Your rewards have been limited to the task price of 75 WXDAI.
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 62.37 |
| Issue | Comment | 1 | 8.07 |
| Review | Comment | 6 | 10.584 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Occasionally there are instances where trusted contributors:1. … | 6.93content:
content:
p:
score: 0
elementCount: 2
ol:
score: 0
elementCount: 1
li:
score: 0.5
elementCount: 4
hr:
score: 0
elementCount: 1
result: 2
regex:
wordCount: 98
wordValue: 0.1
result: 4.93
| 1 | 3 | 62.37 |
Any collaborator can set a label This is unclear but throw an e… | 2.69content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 48
wordValue: 0.1
result: 2.69
| 1 | 3 | 8.07 |
Seems close but study the code elsewhere to see how we do loggin… | 1.38content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 22
wordValue: 0.1
result: 1.38
| 0.7 | 3 | 2.898 |
Syntax should be logger.error | 0.39content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 5
wordValue: 0.1
result: 0.39
| 0.8 | 3 | 0.936 |
We don't use console | 0.39content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 5
wordValue: 0.1
result: 0.39
| 0.75 | 3 | 0.8775 |
Doesn't look right. Review the spec carefully. If I authored t… | 2.15content:
content:
p:
score: 0
elementCount: 2
result: 0
regex:
wordCount: 37
wordValue: 0.1
result: 2.15
| 0.65 | 3 | 4.1925 |
Please post QA and prove it works as expected | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0.4 | 3 | 0.78 |
@gentlementlegen They claim your changes made this harder to tes… | 1content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 15
wordValue: 0.1
result: 1
| 0.3 | 3 | 0.9 |
[ 75 WXDAI ]
@gentlementlegen
⚠️ Your rewards have been limited to the task price of 75 WXDAI.
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Comment | 23 | 180.336 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
`_isCollaborative`, `_nonAssigneeApprovedReviews`… | 1.22content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.1
result: 1.22
| 0.8 | 3 | 2.928 |
Isn't there any equivalent directly with the rest methods? | 0.71content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0.1
result: 0.71
| 0.5 | 3 | 1.065 |
you can remove the `else` and just return `true`… | 0.65content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 9
wordValue: 0.1
result: 0.65
| 0.7 | 3 | 1.365 |
The problem here is that the reviews can still have "APPROVED" s… | 8.29content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 61
wordValue: 0.1
result: 3.29
| 0.9 | 3 | 23.883 |
No need to store that in a variable. | 0.59content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 8
wordValue: 0.1
result: 0.59
| 0.4 | 3 | 0.708 |
Should not need a cast. | 0.39content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 5
wordValue: 0.1
result: 0.39
| 0.4 | 3 | 0.468 |
You can inline this. | 0.32content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 4
wordValue: 0.1
result: 0.32
| 0.6 | 3 | 0.576 |
@ishowvel You can just merge the development branch here and you… | 1.22content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.1
result: 1.22
| 0.3 | 3 | 1.098 |
@ishowvel please delete the `dist` folder so the binary … | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.5 | 3 | 1.245 |
To make sure this compiles, add `"exclude": ["tests"]` i… | 1.06content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 16
wordValue: 0.1
result: 1.06
| 0.7 | 3 | 2.226 |
@ishowvel Could you please merge the development branch here and… | 0.88content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 13
wordValue: 0.1
result: 0.88
| 0.4 | 3 | 1.056 |
I tested this, and it does not work as expected. If the permits … | 7.49content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 44
wordValue: 0.1
result: 2.49
| 0.6 | 3 | 19.482 |
@ishowvel Token for what purpose? What are you trying to achieve? | 0.77content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 11
wordValue: 0.1
result: 0.77
| 0.2 | 3 | 0.462 |
Yes you can use your own token for that and set it in the enviro… | 1.44content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 23
wordValue: 0.1
result: 1.44
| 0.3 | 3 | 1.296 |
You do not have permissions within `ubiquity-os` which i… | 1.17content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 18
wordValue: 0.1
result: 1.17
| 0.3 | 3 | 1.053 |
@ishowvel What is the difference between the logic you implement… | 0.83content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 12
wordValue: 0.1
result: 0.83
| 0.4 | 3 | 0.996 |
Check this test here: https://github.com/Meniole/text-conversati… | 6.65content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 27
wordValue: 0.1
result: 1.65
| 0.8 | 3 | 18.96 |
@ishowvel I don't think there is a `billing_manager` sta… | 1.22content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 19
wordValue: 0.1
result: 1.22
| 0.5 | 3 | 1.83 |
@ishowvel I restarted the Jest site and indeed tests work. Howev… | 7.15content:
content:
p:
score: 0
elementCount: 1
a:
score: 5
elementCount: 1
result: 5
regex:
wordCount: 37
wordValue: 0.1
result: 2.15
| 0.6 | 3 | 18.87 |
@ishowvel I am not sure about what you're asking me exactly, the… | 2content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 34
wordValue: 0.1
result: 2
| 0.2 | 3 | 1.2 |
https://github.com/Meniole/text-conversation-rewards/issues/34… | 10content:
content:
p:
score: 0
elementCount: 2
a:
score: 5
elementCount: 2
result: 10
regex:
wordCount: 0
wordValue: 0.1
result: 0
| 0.1 | 3 | 30 |
@ubiquity-ubiquibot is indeed a collaborator which is why it sho… | 2.15content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 37
wordValue: 0.1
result: 2.15
| 0.7 | 3 | 4.515 |
Seems okhttps://github.com/Meniole/text-conversation-rewards/i… | 15.18content:
content:
p:
score: 0
elementCount: 4
a:
score: 5
elementCount: 3
result: 15
regex:
wordCount: 2
wordValue: 0.1
result: 0.18
| 0.1 | 3 | 45.054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Occasionally there are instances where trusted contributors:
If theres no other collaborator involved in any part of this process, we should refuse to generate the reward until somebody else steps in to reopen and close at least.
Unfortunately after the pull is merged we cant leave a review state other than commented, and it doesnt make sense to change the labels or spec either.
Only admins and billing managers should have this capability. I definitely need it for demo purposes when pitching.
The text was updated successfully, but these errors were encountered: