Refactor/remove supabase #13

Keyrxng · 2024-07-28T23:05:10Z

Resolves #12
May Resolve #10

removes Env and adapters
removes supabase completely
parses the deadline using two comments: the /start response string literal and the follow up comment created_at
adds ubiquibot-logger
new config item watch: {optIn, optOut}
removed the handlers as they only served supabase functionality

Which events should be defined in Supported Events the same as before and just run the plugin on each or is the wildcard the real event that matters?

It would be handy for the /start plugin to log the assignee name in the metadata (I'll add in one of my open PRs) and the responses can be mapped to users more reliably

time.ts is not used in my implementation but if it's preferred/needed I can incorporate it

github-actions · 2024-07-28T23:06:11Z

Unused dependencies (1)

Filename	dependencies
package.json	`typebox-validators`

Unused exports (2)

Filename	exports
src/helpers/get-env.ts	`getGithubIssue`
src/helpers/time.ts	`getTimeEstimate`

Unused types (1)

Filename	types
src/types/github-types.ts	`GetRepo`

0x4007 · 2024-07-29T05:03:25Z

I suppose this is sort of double dipping tasks, perhaps it makes sense to consolidate into a single task #10

src/run.ts

src/helpers/get-env.ts

Keyrxng · 2024-07-29T17:51:44Z

I suppose this is sort of double dipping tasks, perhaps it makes sense to consolidate into a single task #10

It's not guaranteed that this does resolve #10 and removing supabase was necessary anyway wasn't it? I feel they should be kept separate

src/helpers/get-env.ts

src/worker.ts

src/helpers/get-env.ts

whilefoo · 2024-07-30T11:25:08Z

src/helpers/update-tasks.ts

+  const botComments = comments.filter((o) => o.user?.type === "Bot");
+  const dateRegex = /(?<=<td>)(\w{3}, \w{3} \d{1,2}, \d{1,2}:\d{2} (AM|PM) UTC)(?=<\/td>)/gi;
+  const assignmentRegex = /Ubiquity - Assignment - start -/gi;
+  const botAssignmentComments = sortAndReturn(botComments.filter((o) => assignmentRegex.test(o?.body || "")), "desc");
+  const botFollowup = /this task has been idle for a while. Please provide an update./gi;
+  const botFollowupComments = botComments.filter((o) => botFollowup.test(o?.body || ""));


I think it's not a good idea to rely on matching exact text because they might change. It'd be better if we store data in the comment metadata but I'm not sure if we have this functionality implemented.

The part that was generally available/implemented was the metadata header which could be used as a selector to find the right comment:

I had a generalized function for writing metadata that would add a "comment header" which included the developer defined "metadata class name" and the function caller's name. This was intended to be used as a target for these situations.

https://github.com/ubiquity/ubiquibot/blob/development/src/handlers/shared/structured-metadata.ts#L9

I have successfully written search queries using the GitHub search which leveraged this.

https://t.me/UbiquityDAO/1/32137

That is what you are seeing here is it not?

const assignmentRegex = /Ubiquity - Assignment - start -/gi;



ubiquity-os-marketplace/command-start-stop#2 (comment)

It'd be better if we store data in the comment metadata but I'm not sure if we have this functionality implemented.

I forgot to last night but I will add that minor change into one of my open PRs and include the deadline, the userID etc and it can be mapped easier

I see, this metadata is generated by another plugin, right? Ideally it should be structured like JSON or something similar.
However my point still stands for bot follow-up regex but this can be fixed in a later PR

I just saw this thread, I had the same concern myself
#13 (comment)

Even by using metadata checking for a string seems unreliable and easily breakable. What is the purpose of checking for this bot comment?

src/helpers/update-tasks.ts

src/types/plugin-inputs.ts

0x4007 · 2024-07-31T04:31:43Z

I suppose this is sort of double dipping tasks, perhaps it makes sense to consolidate into a single task #10

It's not guaranteed that this does resolve #10 and removing supabase was necessary anyway wasn't it? I feel they should be kept separate

I don't know enough about the problem to say definitively either way.

Keyrxng · 2024-08-07T00:05:22Z

I didn't want to mess around with collect-linked-pulls.ts as it seems like quite a bit of work may have went into it, it felt rude almost to just remove it and it works so no need really.

I said to whilefoo that the search.issuesAndPullRequests is very OP earlier and it looks like it can be used to track linked PRs. I haven't tested it but I think nearly all codebases that require linkedPR tracking each has a unique way of doing it, maybe this the search endpoint is the simplest and most reliable? Thoughts on that?

0x4007 · 2024-08-07T00:27:36Z

I didn't want to mess around with collect-linked-pulls.ts as it seems like quite a bit of work may have went into it, it felt rude almost to just remove it and it works so no need really.

The link doesn't work for me but the file name sounds familiar. Im pretty sure I authored it and it's fine to delete obsolete code.

I said to whilefoo that the search.issuesAndPullRequests is very OP earlier and it looks like it can be used to track linked PRs. I haven't tested it but I think nearly all codebases that require linkedPR tracking each has a unique way of doing it, maybe this the search endpoint is the simplest and most reliable? Thoughts on that?

If it is more reliable then we should switch to this approach.

whilefoo · 2024-08-07T10:15:17Z

I said to whilefoo that the search.issuesAndPullRequests is very OP earlier and it looks like it can be used to track linked PRs.

I can see that you can filter PRs that have linked issues, but how can you specify that you only want PRs that are linked to a particular issue?

Keyrxng · 2024-08-07T12:08:14Z

I said to whilefoo that the search.issuesAndPullRequests is very OP earlier and it looks like it can be used to track linked PRs.

I can see that you can filter PRs that have linked issues, but how can you specify that you only want PRs that are linked to a particular issue?

repo:ubiquibot/user-activity-watcher is:open linked:issue "resolves #12" works fine. It is also case-insensitive regarding Resolves after manually testing via the UI. Some approaches consider other prefixes, idk how accurate it would be if we actually used the other regex captures but.

Thoughts?

gentlementlegen · 2024-08-07T13:28:06Z

@Keyrxng I also like using the search api because it is powerful and reliable. If it works as expected and gives the same results, it would be great to replace the current code base with it because that wound greatly reduce the code base thus lowering the amount of possible bugs.

whilefoo · 2024-08-10T16:22:56Z

repo:ubiquibot/user-activity-watcher is:open linked:issue "resolves #12" works fine. It is also case-insensitive regarding Resolves after manually testing via the UI. Some approaches consider other prefixes, idk how accurate it would be if we actually used the other regex captures but.

Thoughts?

I don't think this will work if the PR was linked via UI, however this already doesn't work with the current approach anyway because even though it relies on events, it still checks the comment. So I guess using search is still a better approach.

"resolves #12" will match any comment so we should limit to the PR description with in:body.
It would be also good to match other keywords. Github doesn't have any docs on boolean operators but it seems to work using OR: is:pr is:open in:body "closes #14" OR "resolves #14"

src/handlers/collect-linked-pulls.ts

.gitignore

src/helpers/update-tasks.ts

src/run.ts

gentlementlegen

I am fine with this, I guess it will be way more performant once we get #15 in.

Keyrxng added 9 commits July 28, 2024 20:52

chore: remove supabase refs and env from context

c5af5ca

chore: remove handlers and proxy

803ef04

chore: config watch item helpers

ba2c49b

feat: ubiquibot-logger

1eac2e5

chore: types, inputs and context

b199f3d

refactor: supabase usage

d37e779

chore: refactor tests

dd4cd6d

chore: include followup comments as lastCheck

207f75b

fix: deadline parsing

23c2f38

Keyrxng requested review from whilefoo and gentlementlegen July 28, 2024 23:05

0x4007 reviewed Jul 29, 2024

View reviewed changes

src/run.ts Outdated Show resolved Hide resolved

src/helpers/get-env.ts Outdated Show resolved Hide resolved

chore: fix ci and kernel response

52f3009

whilefoo suggested changes Jul 30, 2024

View reviewed changes

Keyrxng added 3 commits July 30, 2024 20:29

chore: refactor url parsing methods

1041ab8

chore: fix getAssigneeActivity

e9966d1

chore: activity filtering and date fix

36db7ed

Keyrxng added 4 commits July 31, 2024 21:06

chore: comment metadata parsing

f82453d

chore: no multi org

6a8ed0a

refactor: remove worker logic

1d3dabc

chore: yarn lock

15c11b5

Keyrxng mentioned this pull request Aug 5, 2024

Chore/testing #15

Merged

chore: use search API

29d1c87

gentlementlegen reviewed Aug 19, 2024

View reviewed changes

src/handlers/collect-linked-pulls.ts Show resolved Hide resolved

gentlementlegen reviewed Aug 19, 2024

View reviewed changes

.gitignore Show resolved Hide resolved

gentlementlegen reviewed Aug 19, 2024

View reviewed changes

src/helpers/update-tasks.ts Show resolved Hide resolved

gentlementlegen reviewed Aug 19, 2024

View reviewed changes

src/helpers/update-tasks.ts Show resolved Hide resolved

gentlementlegen reviewed Aug 22, 2024

View reviewed changes

src/run.ts Show resolved Hide resolved

gentlementlegen mentioned this pull request Aug 23, 2024

Add Warning #17

Closed

gentlementlegen approved these changes Aug 23, 2024

View reviewed changes

whilefoo approved these changes Aug 23, 2024

View reviewed changes

0x4007 merged commit bb2c570 into ubiquity-os-marketplace:development Aug 24, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/remove supabase #13

Refactor/remove supabase #13

Keyrxng commented Jul 28, 2024 •

edited

Loading

github-actions bot commented Jul 28, 2024

0x4007 commented Jul 29, 2024

Keyrxng commented Jul 29, 2024

whilefoo Jul 30, 2024

0x4007 Jul 31, 2024 •

edited

Loading

Keyrxng Jul 31, 2024

whilefoo Aug 2, 2024

gentlementlegen Aug 19, 2024

0x4007 commented Jul 31, 2024

Keyrxng commented Aug 7, 2024

0x4007 commented Aug 7, 2024

whilefoo commented Aug 7, 2024

Keyrxng commented Aug 7, 2024

gentlementlegen commented Aug 7, 2024

whilefoo commented Aug 10, 2024

gentlementlegen left a comment

Refactor/remove supabase #13

Refactor/remove supabase #13

Conversation

Keyrxng commented Jul 28, 2024 • edited Loading

github-actions bot commented Jul 28, 2024

Unused dependencies (1)

Unused exports (2)

Unused types (1)

0x4007 commented Jul 29, 2024

Keyrxng commented Jul 29, 2024

whilefoo Jul 30, 2024

Choose a reason for hiding this comment

0x4007 Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

Keyrxng Jul 31, 2024

Choose a reason for hiding this comment

whilefoo Aug 2, 2024

Choose a reason for hiding this comment

gentlementlegen Aug 19, 2024

Choose a reason for hiding this comment

0x4007 commented Jul 31, 2024

Keyrxng commented Aug 7, 2024

0x4007 commented Aug 7, 2024

whilefoo commented Aug 7, 2024

Keyrxng commented Aug 7, 2024

gentlementlegen commented Aug 7, 2024

whilefoo commented Aug 10, 2024

gentlementlegen left a comment

Choose a reason for hiding this comment

Keyrxng commented Jul 28, 2024 •

edited

Loading

0x4007 Jul 31, 2024 •

edited

Loading