Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/testing #15

Merged

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Aug 5, 2024

Resolves #14
Requires #13

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Unused types (1)

Filename types
src/types/github-types.ts IssuesSearch

@Keyrxng Keyrxng marked this pull request as ready for review August 6, 2024 23:48
.gitignore Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Aug 16, 2024

How is this pull coming along?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Aug 16, 2024

How is this pull coming along?

I'm not sure whether this is a blocker or not but I feel good with how things are code wise.

I will produce manual QA for PRs which don't have any later today, this being one of them

@gentlementlegen
Copy link
Member

It would be nice to have Graphql config, similar to the one mentioned here.

Copy link
Member

@gentlementlegen gentlementlegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/helpers/get-assignee-activity.ts Outdated Show resolved Hide resolved
src/helpers/task-metadata.ts Outdated Show resolved Hide resolved
src/helpers/task-deadline.ts Outdated Show resolved Hide resolved
@@ -27,7 +27,7 @@ export async function handleCommentsAndMetadata(
DateTime.fromISO(a.created_at).toMillis() - DateTime.fromISO(b.created_at).toMillis()
)

const botFollowup = /this task has been idle for a while. Please provide an update./gi;
const botFollowup = /<!-- Ubiquity - Followup - remindAssignees/gi;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can use the real metadata parser, the original one I wrote.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to it I don't think I've seen it before

@ubiquity-os ubiquity-os bot merged commit 7ab97aa into ubiquity-os-marketplace:development Aug 29, 2024
2 checks passed
@gentlementlegen
Copy link
Member

gentlementlegen commented Aug 29, 2024

Interesting that the bot didn't care about your comments @0x4007 for activity. Also, the skipBotEvents didn't seem to work, no rewards have been generated. It is properly set here.

Related logs.

@0x4007
Copy link
Member

0x4007 commented Aug 29, 2024

I don't understand why reliability is decreasing

@gentlementlegen
Copy link
Member

It is using lots of new features we never tried before. Nothing to do with conversation-rewards capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tests
4 participants