Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: member role inside of given repository checks #116

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Dec 29, 2024

Resolves #114
QA: Meniole#52 (comment) (ubiquibot is an outside collaborator with write permissions)

@0x4007
Copy link
Member

0x4007 commented Jan 1, 2025

@gentlementlegen will you be able to prioritize this?

@gentlementlegen
Copy link
Member Author

@0x4007 Yes waiting on your input about #114 (comment)

@gentlementlegen gentlementlegen marked this pull request as ready for review January 3, 2025 07:23
Copy link
Member

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes, my only concern is that we will have to declare max concurrent tasks for every permission (write, read, ...) and it might be confusing

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jan 4, 2025

@whilefoo maybe we could simplify to just collaborator and contributor, and then map a group of roles to these two? Admin would just have no limits. I can do that in a secondary pull-request. @0x4007 rfc

@0x4007
Copy link
Member

0x4007 commented Jan 4, 2025

That sounds like a good plan.

@gentlementlegen gentlementlegen merged commit 89170cf into ubiquity-os-marketplace:development Jan 4, 2025
2 checks passed
@gentlementlegen gentlementlegen deleted the fix/member-role branch January 4, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check collaborator status for users
3 participants