Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify role limits by grouping all the roles under "collaborator" and "contributor" #118

Closed
gentlementlegen opened this issue Jan 4, 2025 · 3 comments · Fixed by #119

Comments

@gentlementlegen
Copy link
Member

gentlementlegen commented Jan 4, 2025

          @whilefoo maybe we could simplify to just `collaborator` and `contributor`, and then map a group of roles to these two? Admin would just have no limits. I can do that in a secondary pull-request. @0x4007 rfc

Originally posted by @gentlementlegen in #116 (comment)

To simplify the roles and avoid a long and complex configuration, we should regroup roles under collaborator (anyone with write access or from the organization) and contributor (everyone else). Admins should have no limits.

Copy link

ubiquity-os-beta bot commented Jan 4, 2025

Copy link

Important

  • Be sure to link a pull-request before the first reminder to avoid disqualification.
  • Reminders will be sent every 7 days if there is no activity.
  • Assignees will be disqualified after 14 days of inactivity.

Copy link

ubiquity-os-beta bot commented Jan 12, 2025

 [ 67.58 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask150
IssueSpecification117.58
Conversation Incentives
CommentFormattingRelevancePriorityReward
@whilefoo maybe we could simplify to just `collaborator`…
8.79
content:
  content:
    p:
      score: 0
      elementCount: 3
    em:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 72
  wordValue: 0.1
  result: 3.79
1217.58

 [ 12.948 WXDAI ] 

@whilefoo
Contributions Overview
ViewContributionCountReward
ReviewComment212.948
Conversation Incentives
CommentFormattingRelevancePriorityReward
since admin is not in settings anymore how would one restrict a …
1.06
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 16
  wordValue: 0.1
  result: 1.06
0.921.908
Maybe I'm missing something but for example if I set empty array…
6.9
content:
  content:
    p:
      score: 0
      elementCount: 1
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 32
  wordValue: 0.1
  result: 1.9
0.8211.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants