fix: users now can start again after a /stop command
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
approved these changes
Dec 28, 2024
gentlementlegen
merged commit d80c772
into
ubiquity-os-marketplace:development
2 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69
QA: Meniole#51
What are the changes
The bot was not behaving properly although the codebase was correct, it was in fact only working in the production version because basically the
BOT_USER_IDwas not set properly for the development` version, which I corrected in the environment settings in this repo.But reading the codebase I found that you could abuse the system by stacking
/stopcomments which would nullify bot un-assignment count and let you start again. So I changed the logic instead to check by assignment periods and determine what was the reason of un-assign: bot, user, or admin. Otherwise, logic remains unchanged.