/stop can start again #69

0x4007 · 2024-10-27T22:47:05Z

example

Calling stop should not penalize. If they called stop they should be able to reassign in the future becauss its not a disqualification.

ishowvel · 2024-10-28T07:07:56Z

/start

ubiquity-os-beta · 2024-10-28T07:08:03Z

Deadline Mon, Oct 28, 8:08 AM UTC Beneficiary 0x340D8d2bd82dEb4f485623453c9F6ad307e6B027

Tip

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

ishowvel · 2024-10-28T13:41:35Z

i have noticed that only 1 plugin works in the kernel at the time, my pricing plugin doesnt work when i add this start stop plugin to the .ubiquity-os config, the kernel only forwards the payload to one plugin for some reason

ishowvel · 2024-10-28T13:50:51Z

this may already be implemented

ishowvel · 2024-10-28T13:50:55Z

/stop

ishowvel · 2024-10-28T13:51:04Z

/start

ubiquity-os-beta · 2024-10-28T13:51:11Z

! ishowvel you were previously unassigned from this task. You cannot be reassigned.

ishowvel · 2024-10-28T14:15:35Z

@gentlementlegen might you know why the kernel is only forwarding payload to the first plugin found in any repo containing the ubiquity-os config like found here

[wrangler:inf] POST /events 200 OK (1397ms)
Creating empty kv KvNamespace {}
Event issue_comment received (id: bae1fd80-9536-11ef-8375-aa28c5354825)
Skipping plugin chain Assistive pricing because command does not match. {
  allow: {
    'ubiquity:example': '/allow @user1 label',
    description: 'Allows the user to modify the given label.'
  }
}
[wrangler:inf] POST /events 200 OK (1009ms)

ishowvel · 2024-10-28T14:15:57Z

the kernel doesnt even know if these plugins exist

0x4007 · 2024-10-28T14:47:36Z

My best guess is that you have a formatting problem in your yml config. Sometimes it's difficult to get the indentations perfectly.

gentlementlegen · 2024-10-28T15:33:34Z

It is trying to forward it but what it received is not a valid command like /label. Plugins react only to certain events / inputs.

ishowvel · 2024-10-28T16:28:52Z

Shouldn't it receive the valid commands for this plugin ie /start, /stop

gentlementlegen · 2024-10-28T16:59:45Z

In the configuration file you gave, you chained plugins so it won't. You need to change it to something like

plugins:
  - uses:
    - plugin: http://127.0.0.1:4000
      with:
        labels:
          time:
            - "Time: <15 Minutes"
            - "Time: <1 Hour"
            - "Time: <2 Hours"
            - "Time: <4 Hours"
            - "Time: <1 Day"
            - "Time: <1 Week"
            - "Time: <2 Weeks"
            - "Time: <1 Month"
          priority:
            - "Priority: 1 (Normal)"
            - "Priority: 2 (Medium)"
            - "Priority: 3 (High)"
            - "Priority: 4 (Urgent)"
            - "Priority: 5 (Emergency)"
        basePriceMultiplier: 2
        publicAccessControl:
          setLabel: true
          fundExternalClosedIssue: false
  -  uses:
    - plugin: ishowvel/daemon-disqualifier:compute.yml@testing
      with:
        disqualification: "2 minutes"
        warning: "1 minutes"
        watch:
          optOut:
            - "repoName"
            - "repoName2"
        eventWhitelist:
          - "review_requested"
          - "ready_for_review"
          - "commented"
          - "committed"
  - uses:
    - plugin: http://localhost:4001 # or the URL where the plugin is hosted
      name: start-stop
      id: start-stop-command
      with:
        reviewDelayTolerance: "3 Days"
        taskStaleTimeoutDuration: "30 Days"
        maxConcurrentTasks: # Default concurrent task limits per role.
          member: 5
          contributor: 3
        startRequiresWallet: true # default is true
        emptyWalletText: "Please set your wallet address with the /wallet command first and try again."
        rolesWithReviewAuthority: ["MEMBER", "OWNER"]

so every plugin is called individually.

ishowvel · 2024-10-31T18:33:51Z

@0x4007 can i be assigned to this

ubiquity-os-beta · 2024-10-31T18:54:23Z

@ishowvel the deadline is at Thu, Oct 31, 7:54 PM UTC

ubiquity-os-beta · 2024-10-31T18:55:13Z

A new workroom has been created for this task. Join chat

ishowvel · 2024-11-01T05:52:47Z

@0x4007 i cant seem to recreate the issue

ishowvel · 2024-11-01T05:53:47Z

the problem for me was i was using the github app id as the BOT_USER_ID but instead i should have used

0x4007 · 2024-11-01T19:18:52Z

Show me the conversation/QA on GitHub so I have context on your problem

ishowvel · 2024-11-02T07:10:39Z

ishowvel-org/.ubiquity-os#4
After a certain point i switched the BOT_USER_ID from the GitHub app Id to the GitHub app user id

0x4007 · 2024-11-02T07:22:17Z

It looks like it works. @gentlementlegen rfc

gentlementlegen · 2024-11-02T07:36:57Z

It should not, otherwise it means that users can also assign themselves again after disqualification.

ubiquity-os-beta · 2024-11-08T17:59:31Z

! ariesgun you were previously unassigned from this task. You cannot be reassigned.

ariesgun · 2024-11-08T18:09:59Z

Cannot assign the issue to me anymore.

BOT_USER_ID === payload.user.type === "BOT" && payload.user.login === "UbiquityOS"

Not sure if this is what is used in the code, but shouldn't it be

rest.user.getByUsername("ubiquity-os-beta[bot]").data.id

Keyrxng · 2024-11-08T21:32:53Z

Cannot assign the issue to me anymore.

BOT_USER_ID === payload.user.type === "BOT" && payload.user.login === "UbiquityOS"

Not sure if this is what is used in the code, but shouldn't it be
rest.user.getByUsername("ubiquity-os-beta[bot]").data.id

Yeah sorry you are correct it's probably better to use -beta[bot] than just ubiquity-os[bot] but you get the idea it's user.id of the bot entity

ariesgun · 2024-11-08T22:12:27Z

Cannot assign the issue to me anymore.

BOT_USER_ID === payload.user.type === "BOT" && payload.user.login === "UbiquityOS"

Not sure if this is what is used in the code, but shouldn't it be
rest.user.getByUsername("ubiquity-os-beta[bot]").data.id
Yeah sorry you are correct it's probably better to use -beta[bot] than just ubiquity-os[bot] but you get the idea it's user.id of the bot entity

I see.. so for this issue, is it possible to verify if the BOT_USER_ID in dev.vars is set properly or not?
If I look inside function,

command-start-stop/src/handlers/shared/start.ts

Line 181 in 00c8675

if (await hasUserBeenUnassigned(context, username)) {

,

the most probable root cause is the event.actorId !== BOT_USER_ID

Keyrxng · 2024-11-08T22:14:17Z

The cause is likely because we have two bots and so we have two BOT_USER_IDs to compare. Perhaps it makes sense to add both bot ids and check the actor.id against both?

That is just an assumption obviously but to answer the question: TypeBox verifies that the env vars are defined. Whether they reflect our actual bot is another question, we opt'd for the ID over the username a while back although if there is no other clean solution it'll have to do.

ariesgun · 2024-11-08T22:34:38Z

Or just check for [bot] in the actorname?

Keyrxng · 2024-11-08T22:36:26Z

Or just check for [bot] for the actorname?

That's a quick fix I guess yes.

The original intention behind specifying it's our bot was so that in a partner org where they may have lots of little bots installed that perform actions on tasks and PRs this avoids any interference with our logic.

gentlementlegen · 2024-11-09T02:34:01Z

I think it is safe to assume that a bot un-assign action is from our bot, and would cover both cases.

ariesgun · 2024-11-09T08:41:48Z

If it is agreed to do it this way, (check name for [bot] I can make the changes quickly .
Can you assign this task to me again?

Keyrxng · 2024-11-09T16:11:41Z

@ariesgun Sounds to me like it was implied so yeah go ahead with that solution. I can't assign you but you can link the PR and you'll be assigned when someone else sees this

gentlementlegen · 2024-11-10T01:16:07Z

@ariesgun i think you should check for the user type to be a bot instead.

ubiquity-os-beta · 2024-11-20T08:30:12Z

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

ariesgun · 2024-11-20T08:30:49Z

@0x4007 , is it possible to start this task?

ubiquity-os-beta · 2024-12-12T20:16:57Z

! This task does not reflect a business priority at the moment. You may start tasks with one of the following labels: Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

Sadaf-A · 2024-12-20T21:25:41Z

/start

ubiquity-os-beta · 2024-12-20T21:25:52Z

Warning! This task was created over 53 days ago. Please confirm that this issue specification is accurate before starting. Deadline Fri, Dec 20, 10:25 PM UTC Beneficiary 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tip

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Sadaf-A · 2024-12-20T21:29:10Z

/stop

ubiquity-os-beta · 2024-12-27T06:35:54Z

Deadline Fri, Dec 27, 7:35 AM UTC Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

ubiquity-os-beta · 2024-12-28T23:15:58Z

+ Evaluating results. Please wait...

ubiquity-os-beta · 2024-12-28T23:16:55Z

[ 27.81 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	25
Issue	Comment	7	2.81
Review	Comment	1	0

Conversation Incentives

Comment	Formatting	Relevance	Priority	Reward
It is trying to forward it but what it received is not a valid c…	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0	1	0
In the configuration file you gave, you chained plugins so it wo…	1.65 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 27 wordValue: 0.1 result: 1.65	0	1	0
It should not, otherwise it means that users can also assign the…	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	1	1	0.25
No I mean that if no code was changed, it should not allow re-as…	1.22 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 19 wordValue: 0.1 result: 1.22	1	1	0.31
The `BOT_USER_ID` should match the id of the app your in…	6.59 content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 26 wordValue: 0.1 result: 1.59	1	1	1.65
I think it is safe to assume that a bot un-assign action is from…	1.38 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0.1 result: 1.38	1	1	0.35
@ariesgun i think you should check for the user type to be a bot…	1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1	1	1	0.25
Resolves #69QA: https://github.com/Meniole/command-start-stop/…	6 content: content: p: score: 0 elementCount: 4 h2: score: 1 elementCount: 1 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 104 wordValue: 0 result: 0	0.9	1	0

[ 8.074 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	6.49
Issue	Comment	4	1.584

Conversation Incentives

Comment	Formatting	Relevance	Priority	Reward
example https://github.com/ubiquity/ts-template/issues/61#issue…	6.49 content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 24 wordValue: 0.1 result: 1.49	1	1	6.49
My best guess is that you have a formatting problem in your yml …	1.44 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0.5	1	0.72
Show me the conversation/QA on GitHub so I have context on your …	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.2	1	0.188
It looks like it works. @gentlementlegen rfc	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	0.3	1	0.156
Disqualification and self unassignment are different things	0.52 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0.1 result: 0.52	1	1	0.52

[ 3.49 WXDAI ]
@ariesgun

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	5	3.49

Conversation Incentives

Comment	Formatting	Relevance	Priority	Reward
Cannot assign the issue to me anymore.Not sure if this is what…	1.44 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44	0	1	0
I see.. so for this issue, is it possible to verify if the `…	6.85 content: content: p: score: 0 elementCount: 4 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 31 wordValue: 0.1 result: 1.85	1	1	1.71
Or just check for `[bot]` in the actorname?![image](ht…	5.52 content: content: p: score: 0 elementCount: 2 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 7 wordValue: 0.1 result: 0.52	1	1	1.38
If it is agreed to do it this way, (check name for `[bot] …	1.59 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 26 wordValue: 0.1 result: 1.59	1	1	0.4
@0x4007 , is it possible to start this task?	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0	1	0

[ 2.07 WXDAI ]
@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	5	2.07

Conversation Incentives

Comment	Formatting	Relevance	Priority	Reward
`BOT_USER_ID` === `payload.user.type === "BOT" &…	1.38 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 22 wordValue: 0.1 result: 1.38	0.5	1	0.175
Yeah sorry you are correct it's probably better to use `-bet…	1.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 26 wordValue: 0.1 result: 1.59	0.5	1	0.2
The cause is likely because we have two bots and so we have two …	4.41 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 86 wordValue: 0.1 result: 4.41	1	1	1.1
That's a quick fix I guess yes.The original intention behind s…	2.64 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 47 wordValue: 0.1 result: 2.64	0.5	1	0.33
@ariesgun Sounds to me like it was implied so yeah go ahead with…	2.1 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 36 wordValue: 0.1 result: 2.1	0.5	1	0.265

0x4007 added Time: <1 Hour Priority: 1 (Normal) labels Oct 27, 2024

ubiquity-os-beta bot added the Price: 25 USD label Oct 27, 2024

devpool-directory-superintendent bot mentioned this issue Oct 27, 2024

/stop can start again ubiquity/devpool-directory#1799

Closed

This comment was marked as off-topic.

Sign in to view

ubiquity-os-beta bot assigned ishowvel Oct 28, 2024

ubiquity-os-beta bot unassigned ishowvel Oct 28, 2024

0x4007 assigned ishowvel Oct 31, 2024

ariesgun mentioned this issue Nov 10, 2024

fix: check for actor type bot in unassigned events #83

Closed

ubiquity-os-beta bot added Price: 25 USD and removed Price: 25 USD labels Dec 4, 2024

ubiquity-os-beta bot added the Price: 25 USD label Dec 12, 2024

ubiquity-os-beta bot assigned Sadaf-A Dec 20, 2024

ubiquity-os-beta bot unassigned Sadaf-A Dec 20, 2024

gentlementlegen mentioned this issue Dec 27, 2024

fix: users now can start again after a /stop command #113

Merged

ubiquity-os-beta bot assigned gentlementlegen Dec 27, 2024

gentlementlegen closed this as completed in #113 Dec 28, 2024

/stop can start again #69

/stop can start again #69

Comments

0x4007 commented Oct 27, 2024

This comment was marked as off-topic.

ishowvel commented Oct 28, 2024

ubiquity-os-beta bot commented Oct 28, 2024

ishowvel commented Oct 28, 2024

ishowvel commented Oct 28, 2024

ishowvel commented Oct 28, 2024

ishowvel commented Oct 28, 2024

ubiquity-os-beta bot commented Oct 28, 2024

ishowvel commented Oct 28, 2024

ishowvel commented Oct 28, 2024

0x4007 commented Oct 28, 2024

gentlementlegen commented Oct 28, 2024

ishowvel commented Oct 28, 2024

gentlementlegen commented Oct 28, 2024 • edited Loading

ishowvel commented Oct 31, 2024

ubiquity-os-beta bot commented Oct 31, 2024

ubiquity-os-beta bot commented Oct 31, 2024

ishowvel commented Nov 1, 2024

ishowvel commented Nov 1, 2024

0x4007 commented Nov 1, 2024 • edited Loading

ishowvel commented Nov 2, 2024

0x4007 commented Nov 2, 2024

gentlementlegen commented Nov 2, 2024

ubiquity-os-beta bot commented Nov 8, 2024

ariesgun commented Nov 8, 2024

Keyrxng commented Nov 8, 2024

ariesgun commented Nov 8, 2024

Keyrxng commented Nov 8, 2024 • edited Loading

ariesgun commented Nov 8, 2024 • edited Loading

Keyrxng commented Nov 8, 2024

gentlementlegen commented Nov 9, 2024

ariesgun commented Nov 9, 2024

Keyrxng commented Nov 9, 2024

gentlementlegen commented Nov 10, 2024

ubiquity-os-beta bot commented Nov 20, 2024

ariesgun commented Nov 20, 2024

ubiquity-os-beta bot commented Dec 12, 2024

Sadaf-A commented Dec 20, 2024

ubiquity-os-beta bot commented Dec 20, 2024

Sadaf-A commented Dec 20, 2024

ubiquity-os-beta bot commented Dec 27, 2024

ubiquity-os-beta bot commented Dec 28, 2024

ubiquity-os-beta bot commented Dec 28, 2024

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

gentlementlegen commented Oct 28, 2024 •

edited

Loading

0x4007 commented Nov 1, 2024 •

edited

Loading

Keyrxng commented Nov 8, 2024 •

edited

Loading

ariesgun commented Nov 8, 2024 •

edited

Loading