Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z CAM E1 fixes #64

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Z CAM E1 fixes #64

wants to merge 8 commits into from

Commits on Jun 11, 2019

  1. Configuration menu
    Copy the full SHA
    d910651 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13c01df View commit details
    Browse the repository at this point in the history
  3. z-cam-e1: update the tests to match

    We've now got an (optional) param in the z-cam backend that will skip the configuration ritual, mostly for the sake of testing (I don't really see much sense in mocking all of the endpoints we hit while configuring the camera).
    This param doesn't have a matching env var; I don't think this is something that we'll actually use outside of for tests.
    rrbutani committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    fa79bcc View commit details
    Browse the repository at this point in the history
  4. z-cam-e1: fix nock headers being encoded to a JSON string

    This was causing the test to fail, as nock expects the headers to be
    given as an object instead of a string, which made nock send invalid
    imagery data and the `removeOrientation` function failed due to it not
    being an actual JPEG image.
    bbridges committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    73c61c5 View commit details
    Browse the repository at this point in the history
  5. z-cam-e1: wait until configuration is sent to continue

    Before all the params were dispatched into the background, and failures
    would not be caught, this will wait until they have all completed and
    were succesful.
    
    Otherwise, this would print out a bunch of
    `UnhandledPromiseRejectionWarning`s.
    
    Also `_makeReq` -> `_setParam` as it was before.
    bbridges committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    fcf3bac View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    44f4c68 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Configuration menu
    Copy the full SHA
    9b91368 View commit details
    Browse the repository at this point in the history
  2. z-cam-e1: more tweaks from before competition

    This was the only configuration that actually worked on the camera.
    
    The options that are commented out aren't strictly necessary and we ditched them in the interest of time. If we want to be thorough, someone should check that they work as expected with the camera.
    
    Also, there's some subtle/undocumented behavior for some of the options:
      - sharpness can't actually be set (see: ' Normal ')
      - we set lcd to On, but then set the timeout so that:
        + the screen is off for the flight
        + but, humans can still turn the screen back on without needing to write `curl` commands
      - more in the comments
    rrbutani committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    2c8dc2e View commit details
    Browse the repository at this point in the history