-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z CAM E1 fixes #64
Open
oldmud0
wants to merge
8
commits into
master
Choose a base branch
from
imagery-z-cam
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Z CAM E1 fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've now got an (optional) param in the z-cam backend that will skip the configuration ritual, mostly for the sake of testing (I don't really see much sense in mocking all of the endpoints we hit while configuring the camera). This param doesn't have a matching env var; I don't think this is something that we'll actually use outside of for tests.
This was causing the test to fail, as nock expects the headers to be given as an object instead of a string, which made nock send invalid imagery data and the `removeOrientation` function failed due to it not being an actual JPEG image.
Before all the params were dispatched into the background, and failures would not be caught, this will wait until they have all completed and were succesful. Otherwise, this would print out a bunch of `UnhandledPromiseRejectionWarning`s. Also `_makeReq` -> `_setParam` as it was before.
Heyo! So actually, I'm pretty sure the changes did make it to competition. I've got some last minute tweaks to what you're calling the "extended configuration" from the night before y'all flew out. The same changes are also (or were also) on the plane, but they were never pushed. I can push them later today if you'd like. |
Okay, thanks! |
This was the only configuration that actually worked on the camera. The options that are commented out aren't strictly necessary and we ditched them in the interest of time. If we want to be thorough, someone should check that they work as expected with the camera. Also, there's some subtle/undocumented behavior for some of the options: - sharpness can't actually be set (see: ' Normal ') - we set lcd to On, but then set the timeout so that: + the screen is off for the flight + but, humans can still turn the screen back on without needing to write `curl` commands - more in the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were unmerged changes to the Z CAM E1 imagery backend. I don't think the changes made it to competition.
I'm a little skeptical of the "extended configuration" part. That should probably be moved over to a separate method and be called
reset
orreconfigure
. The main idea is that it places the camera's capture settings in a predictable state.