Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z CAM E1 fixes #64

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Z CAM E1 fixes #64

wants to merge 8 commits into from

Conversation

oldmud0
Copy link
Member

@oldmud0 oldmud0 commented Oct 13, 2019

These were unmerged changes to the Z CAM E1 imagery backend. I don't think the changes made it to competition.

I'm a little skeptical of the "extended configuration" part. That should probably be moved over to a separate method and be called reset or reconfigure. The main idea is that it places the camera's capture settings in a predictable state.

rrbutani and others added 6 commits June 11, 2019 04:05
We've now got an (optional) param in the z-cam backend that will skip the configuration ritual, mostly for the sake of testing (I don't really see much sense in mocking all of the endpoints we hit while configuring the camera).
This param doesn't have a matching env var; I don't think this is something that we'll actually use outside of for tests.
This was causing the test to fail, as nock expects the headers to be
given as an object instead of a string, which made nock send invalid
imagery data and the `removeOrientation` function failed due to it not
being an actual JPEG image.
Before all the params were dispatched into the background, and failures
would not be caught, this will wait until they have all completed and
were succesful.

Otherwise, this would print out a bunch of
`UnhandledPromiseRejectionWarning`s.

Also `_makeReq` -> `_setParam` as it was before.
@rrbutani
Copy link
Member

Heyo! So actually, I'm pretty sure the changes did make it to competition.

I've got some last minute tweaks to what you're calling the "extended configuration" from the night before y'all flew out. The same changes are also (or were also) on the plane, but they were never pushed. I can push them later today if you'd like.

@oldmud0
Copy link
Member Author

oldmud0 commented Oct 13, 2019

Okay, thanks!

This was the only configuration that actually worked on the camera.

The options that are commented out aren't strictly necessary and we ditched them in the interest of time. If we want to be thorough, someone should check that they work as expected with the camera.

Also, there's some subtle/undocumented behavior for some of the options:
  - sharpness can't actually be set (see: ' Normal ')
  - we set lcd to On, but then set the timeout so that:
    + the screen is off for the flight
    + but, humans can still turn the screen back on without needing to write `curl` commands
  - more in the comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants