Skip to content

Commit

Permalink
Back out "Remove toolchain "platform010""
Browse files Browse the repository at this point in the history
Summary:
Original commit changeset: 5ddd8f81f53a

Original Phabricator Diff: D55638359

```
[[email protected] ~/fbsource/fbcode (d6f8ce9e8)]$ arc pull
# back-out
[[email protected] ~/fbsource/fbcode (ecb5475c1)]$ hg backout D55638359
```

Back-out the change due to failures in open source: T184891313 / T184897022 / T184897176.

Checked with malanka, the context why it's using llvm12 is:
> To allow CodeHub navigation for c++ code for the aosp repository (https://www.internalfb.com/code/aosp)  cAST support was added there. And last week we build a Glean Indexing pipeline for C++ code for AOSP. Unfortunately, code in AOSP uses clang12

The reason it's failing

> In D55638374  Dmitry said, that we should wait with the removal because AOSP repository is indexed with llvm12. It seems that it was not clear, that entire stack should wait and landing the D55638359 removed the platform010 indexer entirely from Glean.

> Also, with the failure, we know that we should sort out the open source part of gleran first before deleting the platform010.

Reviewed By: malanka, bunnypak

Differential Revision: D55942695

fbshipit-source-id: d50ca571b88de4963abd6b71c675764d8b255d95
  • Loading branch information
Yu Wu authored and facebook-github-bot committed Apr 10, 2024
1 parent 615c489 commit d9a789b
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -562,7 +562,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -615,7 +615,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -432,7 +432,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -464,7 +464,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -492,7 +492,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -524,7 +524,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -552,7 +552,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -72,7 +72,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -123,7 +123,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -572,7 +572,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -626,7 +626,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -92,7 +92,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -130,7 +130,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -360,7 +360,7 @@
}
}
},
"type": { "key": "N1::Bar<N1::Foo>" },
"type": { "key": "N1::Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down Expand Up @@ -398,7 +398,7 @@
}
}
},
"type": { "key": "Bar<N1::Foo>" },
"type": { "key": "Bar<Foo>" },
"kind": { "local": { "kind": 0, "attribute": 0 } },
"source": {
"file": { "key": "test.cpp" },
Expand Down

0 comments on commit d9a789b

Please sign in to comment.