forked from facebookincubator/Glean
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: enum classes inherit from these member functions https://www.internalfb.com/code/symbol/fbsource/php/HH/BuiltinEnum > Under the hood, an enum Foo will extend BuiltinEnum<Foo>. These relations aren't captured in Glean at the moment. We could get them from [here](https://www.internalfb.com/code/fbsource/[537c193db6f8]/fbcode/hphp/hack/src/typing/write_symbol_info/file_info.ml?lines=114) but they've been filtered out for saving space/indexing time. As a quick fix, I propose to hardcode them it in the schema to unblock itsnauman who requested this. I think they want to use "codemarkup.hack.HackEnumInheritedMembers" but I also added the inheritance relations in the codemarkup inheritance predicates. Reviewed By: itsnauman Differential Revision: D55808239 fbshipit-source-id: 0292ea515244c10b4d441e71ea6112c75cf77152
- Loading branch information
1 parent
990ad18
commit 615c489
Showing
5 changed files
with
33 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters