Use tutasdk for Argon2id on iOS/Android #7361
Merged
Commits on Aug 16, 2024
-
Change ipc schema to not pass argon2id parameters
The SDK does not support custom parameters, not that it matters because they will always be the same. Also, SDK takes string for passphrase, so we can avoid doing conversion by just passing the passphrase as a string.
-
[android] Use tutasdk for argon2id; ~() all C++ code
Remove dependency on phc-winner-argon2 and all C++ code. Add NDK installation to kotlin-test.yml. Before, this was held together with duct tape, and removing the CMakeLists.txt also removed the duct tape, causing CI to complain about no NDK installed even though it was somehow fine before... Co-authored-by: wec43 <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.