Use tutasdk for Argon2id on iOS/Android #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
changed the title
paw-hub
force-pushed
the
7357-argon-sdk
branch
4 times, most recently
from
e8bedc6
to
4e54f9e
Compare
tutao-mac
force-pushed
the
7357-argon-sdk
branch
2 times, most recently
from
beb1f73
to
4b52930
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
6 times, most recently
from
43cdcc2
to
4cab160
Compare
3 tasks
charlag
approved these changes
Aug 9, 2024
app-android/app/src/main/java/de/tutao/tutanota/AndroidNativeCryptoFacade.kt
Outdated
Show resolved
Hide resolved
paw-hub
force-pushed
the
kick-libcrypto
branch
from
c1a87eb
to
3948c17
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
a0e601c
to
a89816a
Compare
paw-hub
force-pushed
the
kick-libcrypto
branch
from
3948c17
to
880477f
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
a89816a
to
715b16c
Compare
paw-hub
force-pushed
the
kick-libcrypto
branch
from
880477f
to
fbc3b43
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
715b16c
to
ba3cc4f
Compare
paw-hub
force-pushed
the
kick-libcrypto
branch
2 times, most recently
from
9801633
to
6a7b8e7
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
ba3cc4f
to
8b073f3
Compare
Jenkins seems to work already! |
paw-hub
force-pushed
the
kick-libcrypto
branch
from
6a7b8e7
to
d0458e5
Compare
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
8b073f3
to
7d60c54
Compare
paw-hub
force-pushed
the
kick-libcrypto
branch
from
d0458e5
to
e2c9eee
Compare
The SDK does not support custom parameters, not that it matters because they will always be the same. Also, SDK takes string for passphrase, so we can avoid doing conversion by just passing the passphrase as a string.
Remove dependency on phc-winner-argon2 and all C++ code. Add NDK installation to kotlin-test.yml. Before, this was held together with duct tape, and removing the CMakeLists.txt also removed the duct tape, causing CI to complain about no NDK installed even though it was somehow fine before... Co-authored-by: wec43 <[email protected]>
Removes libargon2.a dependency
paw-hub
force-pushed
the
7357-argon-sdk
branch
from
7d60c54
to
cb4f177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7357
(this is based on top of
kick-libcrypto)