Fix uploading datapackages from iTAK iOS client #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!link #81 |
|
@Matthew-Beckett Thanks for the pull request! Would you mind splitting out the docker file commits? I'm not quite ready to bring docker and build pipelines into the project, but would love to bring in your commits and credit you for your work! |
deemoowoor
reviewed
May 16, 2024
Comment on lines
+2
to
+5
| pull_request: | ||
| push: | ||
| branches: | ||
| - 'main' |
There was a problem hiding this comment.
You can change these to:
on:
workflow_dispatch:and this workflow will only be activated by manual triggering from the Actions menu
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the datapackage server to implement the upload endpoint used by the iTAK client for sharing datapackages with the server.
Although this implementation works and uploads the files successfully in a manner which appears to work for Android clients. The iOS client returns the same error as previous and still cannot search for datapackages without returning an error.
This PR at least makes it so that aware iOS users can upload datapackages with the knowledge they did indeed succeed and Android users will be able to download them.