[BACK-3183] Add ability to send connection invites for multiple providers #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy qa1 |
|
toddkazakov updated values.yaml file in qa1 |
|
toddkazakov updated flux policies file in qa1 |
|
toddkazakov deployed clinic-worker tk-connect-twiist-2 branch to qa1 namespace |
toddkazakov
force-pushed
the
tk-connect-twiist-2
branch
2 times, most recently
from
2a5fd8c to
8b46d39
Compare
toddkazakov
changed the title
lostlevels
previously approved these changes
Oct 25, 2024
patients/consumer.go
Outdated
| if *source.ProviderName == DexcomDataSourceProviderName && *source.State == string(clinics.DataSourceStatePendingReconnect) { | ||
| templateName = "request_dexcom_reconnect" | ||
| errs := make([]error, 0, len(providers)) | ||
| for providerName, _ := range providers { |
patients/models.go
Outdated
|
|
||
| func (u UpdatedFields) GetUpdatedConnectionRequests() ConnectionRequests { | ||
| var requests ConnectionRequests | ||
| if u.ProviderConnectionRequests != nil { |
There was a problem hiding this comment.
nitpick: You can range over a nil map.
patients/models.go
Outdated
| requests = append(requests, v) | ||
| } | ||
| for _, v := range u.ProviderConnectionRequestsTwiist { | ||
| requests = append(requests, v) |
There was a problem hiding this comment.
Would it be simpler to just do a requests = append(requests, u.ProviderConnectionRequestsTwiist...) and the same for ProviderConnectionRequestsDexcom ?
lostlevels
previously approved these changes
Oct 29, 2024
toddkazakov
force-pushed
the
tk-connect-twiist-2
branch
from
03c90d9 to
1bcfad0
Compare
toddkazakov
force-pushed
the
tk-connect-twiist-2
branch
from
f197413 to
f11a73b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.