Address code review feedback

tidepool-org · Dec 10, 2024 · 1bcfad0 · 1bcfad0
1 parent 6e77878
commit 1bcfad0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/patients/consumer.go b/patients/consumer.go
@@ -205,7 +205,7 @@ func (p *PatientCDCConsumer) handleCDCEvent(event PatientCDCEvent) error {
 		}
 
 		errs := make([]error, 0, len(providers))
-		for providerName, _ := range providers {
+		for providerName := range providers {
 			templatePrefix := fmt.Sprintf("request_%s_", providerName)
 			action := "connect"
 			if event.FullDocument.IsCustodial() {

diff --git a/patients/models.go b/patients/models.go
@@ -178,19 +178,12 @@ type UpdatedFields struct {
 
 func (u UpdatedFields) GetUpdatedConnectionRequests() ConnectionRequests {
 	var requests ConnectionRequests
-	if u.ProviderConnectionRequests != nil {
-		for _, r := range u.ProviderConnectionRequests {
-			for _, v := range  r {
-				requests = append(requests, v)
-			}
-		}
-	}
-	for _, v := range  u.ProviderConnectionRequestsDexcom {
-		requests = append(requests, v)
-	}
-	for _, v := range  u.ProviderConnectionRequestsTwiist {
-		requests = append(requests, v)
+	for _, r := range u.ProviderConnectionRequests {
+		requests = append(requests, r...)
 	}
+	requests = append(requests, u.ProviderConnectionRequestsDexcom...)
+	requests = append(requests, u.ProviderConnectionRequestsTwiist...)
+
 	return requests
 }