Support deployment on Sepolia #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
1 task
This was referenced Sep 5, 2023
lukasz-zimnoch
added a commit
to keep-network/keep-core
that referenced
this pull request
Sep 25, 2023
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Refs: threshold-network/solidity-contracts#150 keep-network/ci#48 threshold-network/solidity-contracts#151 keep-network/tbtc-v2#691 threshold-network/token-dashboard#605 - [ ] Update `TESTNET_ETH_CONTRACT_OWNER_PRIVATE_KEY` so that it is prefixed with `0x`
lukasz-zimnoch
added a commit
to keep-network/tbtc-v2
that referenced
this pull request
Oct 24, 2023
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Refs: threshold-network/solidity-contracts#150 keep-network/ci#48 threshold-network/solidity-contracts#151 keep-network/keep-core#3706 threshold-network/token-dashboard#605
In the commit `c58ee5c078cbe850e678b85a136a4841d1732615` we've started modificating Token Dashboard config to make it run on the Sepolia testnet. In this commit we continue that work. Some configs are still missing - we mark them as TODO.
The merkle drop contract was deployed on Sepolia under the `0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153` address (https://sepolia.etherscan.io/address/0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153).
The `SimplePreApplication` stub contract was deployed on Sepolia under the `0x471EA40981D278fb3Cb55587e94ac549aad1ACA9` address (https://sepolia.etherscan.io/address/0x471EA40981D278fb3Cb55587e94ac549aad1ACA9).
We're bringing back the functionality removed in commit 17e2a0b. Recently we've changed the dapp's `@keep-network/tbtc-v2.ts` dependency to `^2.3.0`, which results in the introduction of the `@threshold-network/[email protected]` package in the `yarn.lock`. That package contains a `prepare-dependencies.sh` script which sometimes causes problems during install/upgrade of the dapp dependencies. As a workaround we install dashboard dependencies with `--ignore-scripts` flag. This way we don't run the misbehaving script (we don't need to run it in this project). In order to run the postinstall scripts related strictly to the `@threshold-network/token-dashboard` project, we manually run the post-install script by executing `yarn run postinstall`.
lukasz-zimnoch
force-pushed
the
support-sepolia
branch
2 times, most recently
from
30d39f9
to
cfaa912
Compare
The workaround for the `expected manifest` problem must resolve the specific version for both `sepolia` and `dapp-development-sepolia` tags, depending on the target environment.
lukasz-zimnoch
force-pushed
the
support-sepolia
branch
from
cfaa912
to
acefbcb
Compare
|
Preview uploaded to https://preview.dashboard.test.threshold.network/support-sepolia/index.html. |
lukasz-zimnoch
force-pushed
the
support-sepolia
branch
from
d8131a5
to
35b01ec
Compare
|
Preview uploaded to https://preview.dashboard.test.threshold.network/support-sepolia/index.html. |
1 similar comment
|
Preview uploaded to https://preview.dashboard.test.threshold.network/support-sepolia/index.html. |
|
Preview uploaded to https://preview.dashboard.test.threshold.network/support-sepolia/index.html. |
lukasz-zimnoch
approved these changes
Nov 23, 2023
This was referenced Nov 27, 2023
Merged
michalsmiarowski
added a commit
to threshold-network/bitcoin-on-base
that referenced
this pull request
Feb 23, 2024
Adds support for Sepolia in local development. The support for preview and deployed testnet version will be addressed in a separate PR. This wa done based on the pull request from T dashbaord repo, where we did the same: threshold-network/token-dashboard#605 (commit: `ae3a4342e79bd822a8db6504c351dd2259d01cfe`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called
Holešky, however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 (source). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
TODO:
0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153(deployed from themerkle-distributionrepo)0x471EA40981D278fb3Cb55587e94ac549aad1ACA9(deployed usingsolidity-contracts/deploy/00_resolve_nucypher_pre_application.ts, withfunc.skipline commented out)NOTE: The PR will be left as draft until we have the client config switched to Sepolia
Refs:
threshold-network/solidity-contracts#150
keep-network/ci#48
threshold-network/solidity-contracts#151
keep-network/keep-core#3706
keep-network/tbtc-v2#691