-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deployment on Sepolia #151
Conversation
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
a1cde6b
to
d1a880d
Compare
There is no scenario were we wouldn't need to provide an `environment` when manually triggering the workflow run.
We don't need to differenciate between Sepolia and Goerli secrets storing private keys of the deployers - in both cases we're using the same deployer address.
We're using the same address to deploy Keep and Threshold contracts on Sepolia as on Goerli.
The Ropsten testnet is depracated.
We've been using the same account to deploy Keep and Threshold contracts (both on Goerli and Sepolia).
9c9decb
to
50abb8f
Compare
@lukasz-zimnoch, I've realized I was missing some changes in order to make a successful deployment and added a couple of commits (and verified locally that contracts now deploy on Sepolia). I wasn't 100% sure if the files in |
Normally, those files should be copied from the EDIT: You can make sure the external contract addresses are resolved properly by console logging |
Yes, the are.
Confirmed, the right TokenStaking address was used ( Package deployed and published successfully: https://www.npmjs.com/package/@threshold-network/solidity-contracts/v/1.3.0-sepolia.0. |
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Refs: threshold-network/solidity-contracts#150 keep-network/ci#48 threshold-network/solidity-contracts#151 keep-network/tbtc-v2#691 threshold-network/token-dashboard#605 - [ ] Update `TESTNET_ETH_CONTRACT_OWNER_PRIVATE_KEY` so that it is prefixed with `0x`
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 ([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Refs: threshold-network/solidity-contracts#150 keep-network/ci#48 threshold-network/solidity-contracts#151 keep-network/keep-core#3706 threshold-network/token-dashboard#605
The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called
Holešky, however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 (source). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
Refs:
#150
keep-network/ci#48
keep-network/keep-core#3706
keep-network/tbtc-v2#691
threshold-network/token-dashboard#605
TODO: