-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mobile article comment #4201
Merged
+804
−148
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0f9b179
feat(ArticleDetail): add CommentsDialog
wlliaml 42c49e0
feat(ArticleDetail): revise CommentsDialog
wlliaml c99b720
feat(ArticleDetail): add CommentFormBetaDialog
wlliaml 2f22e81
feat(ArticleDetail): revise dialog height
wlliaml d4a3efa
feat(Dialog): adjust fixed height
wlliaml 52f2102
feat(ArticleDetail): revise CommentFormBetaDialog
wlliaml ffcd8a1
feat(ArticleDetail): open comment form when comment is empty
wlliaml a497652
feat(ArticleDetail): add CommentDialog.DetailContent
wlliaml 1699822
feat(ArticleDetail): Fixed dialog height when switching dialogs
wlliaml ecf94d8
fix(CommentFormBetaDialog): fix border width
wlliaml 88fcc21
fix(ArticleDetail): fix visitor mode
wlliaml 6ed2633
Merge branch 'New-Article-Page' into feat/mobile-article-comment
wlliaml 3f6bb3c
fix(ArticleDetail): fix horizontal scrolling error
wlliaml 1ce8d47
fix(ArticleDetail): fix typo
wlliaml c86aa1a
fix(Dialog): revise dialog content height
wlliaml 0733f64
fix(Dialog): revise dialog content height
wlliaml 221cbda
fix(ArticleDetail): fix unit test
wlliaml File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export const COMMENTS_COUNT = 15 | ||
export const TOOLBAR_FIXEDTOOLBAR_ID = 'toolbar/fixedToolbar/id' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,13 +2,13 @@ | |
display: flex; | ||
flex-direction: column; | ||
flex-shrink: 1; | ||
max-height: calc(70vh - 4.25rem); /* 4.25rem is the height of header */ | ||
max-height: calc(90vh - 4.25rem); /* 4.25rem is the height of header */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 90vh is not enough space for mobile browser, and it might break other dialogs with |
||
overflow-x: hidden; | ||
overflow-y: auto; | ||
-webkit-overflow-scrolling: touch; | ||
|
||
&.fixedHeight { | ||
height: calc(70vh - 4.25rem); /* 4.25rem is the height of header */ | ||
height: calc(90vh - 4.25rem); /* 4.25rem is the height of header */ | ||
|
||
@media (--sm-up) { | ||
height: min(34rem, 64vh); | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? OPEN_COMMENT_DETAIL_DIALOG?