Feat/mobile article comment #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robertu7
approved these changes
Feb 27, 2024
| @@ -2,13 +2,13 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| flex-shrink: 1; | |||
| max-height: calc(70vh - 4.25rem); /* 4.25rem is the height of header */ | |||
| max-height: calc(90vh - 4.25rem); /* 4.25rem is the height of header */ | |||
There was a problem hiding this comment.
90vh is not enough space for mobile browser, and it might break other dialogs with fixedHeight prop?
src/common/enums/events.ts
Outdated
| @@ -22,6 +22,7 @@ export const CLOSE_ACTIVE_DIALOG = 'closeActiveDialog' | |||
| export const OPEN_SUBSCRIBE_CIRCLE_DIALOG = 'openSubscribeCircleDialog' | |||
| export const OPEN_SET_USER_NAME_DIALOG = 'openSetUserNameDialog' | |||
| export const OPEN_SHOW_NOMAD_BADGE_DIALOG = 'openShowNomadBadgeDialog' | |||
| export const OPEN_ARTICLE_DETAIL_DIALOG = 'openArticleDetailDialog' | |||
There was a problem hiding this comment.
typo? OPEN_COMMENT_DETAIL_DIALOG?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.