-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-.env-from-env - fixes #636 #637
base: develop
Are you sure you want to change the base?
Conversation
Thanks for this, I'll try it soon. |
the bug occurs with docker-composre, and also using helm from https://artifacthub.io/packages/helm/christianknell/kutt or truecharts on truenas (https://github.com/truecharts/charts/tree/master/charts/stable/kutt) i've got that isssue. Maybe because of working base-functionality not everyone checks immediately that there's something wrong. Another idea is just not to use dotenv, but reading process.env directly. |
docker-compose.yml
Outdated
@@ -3,6 +3,7 @@ version: "3" | |||
services: | |||
kutt: | |||
image: kutt/kutt | |||
#build: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, can be omitted. It's just for building local containers from local code
@poeti8 I tested this change here by creating this test docker image. The change works as expected. The site name is shown on the main page and the url in the This PR fixes multiple issues. Great finding and good work @fashberg |
next.config.js is using
require("dotenv").config();
- but there is no .env inside the container!The .env is outside the container when using docker-compose. Documentation says nothing about this.
I've added an entrypoint.sh which creates an
.env
-file from the ENV-Variables .Fixes #636