Fix: empty publicRuntimeEnvironment in docker and Kubernetes
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like #637 addresses the same issue using a different approach |
|
@fashberg what do you think about this approach? |
dkyeremeh
commented
Dec 7, 2022
Comment on lines
+5
to
+6
| export const { DISALLOW_ANONYMOUS_LINKS } = publicRuntimeConfig; | ||
| export const { DISALLOW_REGISTRATION } = publicRuntimeConfig; |
There was a problem hiding this comment.
No longer necessary to compare the value with 'true'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656 #636
Issue #656 occurs because the configuration
DISALLOW_ANONYMOUS_LINKSis not available topublicRuntimeConfigwhen using container orchestration.
This PR allows both .env file and values from
process.envto be used to configure app, making it possible to use any type of environmental variables