refactor WalletConnectAuth using signCustomTransaction() #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mauthenticators' of https://github.com/telosnetwork/telos-wallet into 626-refactor-walletconnectauth-using-signcustomtransaction
✅ Deploy Preview for wallet-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wallet-develop-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viterbo
changed the base branch from
develop
to
epic/623-custom-contract-function-support
…actor-walletconnectauth-using-signcustomtransaction
donnyquixotic
approved these changes
Oct 17, 2023
donnyquixotic
merged commit 7150022
into
epic/623-custom-contract-function-support
1 check passed
donnyquixotic
deleted the
626-refactor-walletconnectauth-using-signcustomtransaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #626
Description
This PR includes the refactoring of the class WalletConnectAuth to support new custom contract functions. The bug blocking this PR was solved so now this work can be tested and reviewed.
Test scenarios
Test scenarios
All should work as always.
Checklist: