Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WalletConnectAuth using signCustomTransaction #626

Closed
Viterbo opened this issue Oct 3, 2023 · 0 comments · Fixed by #637
Closed

Refactor WalletConnectAuth using signCustomTransaction #626

Viterbo opened this issue Oct 3, 2023 · 0 comments · Fixed by #637
Assignees
@Viterbo

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Oct 3, 2023 •
edited
Loading

Description

This issue is part of a group of issues that aims to migrate part of the Antelope library to the Teloscan Website. For this, the generic signCustomTransaction function must be implemented and at the same time reimplement the existing ones using the new function.

Tasks

  • Implement for real the signCustomTransaction on WalletConnectAuth class
  • Refactor all other specific functions calling the new generic signCustomTransaction with the correct parameters
@Viterbo Viterbo mentioned this issue Oct 3, 2023
Closed
@Viterbo Viterbo added 🚫 Blocked Can't proceed with this issue or pull request and removed 🚫 Blocked Can't proceed with this issue or pull request labels Oct 3, 2023
@Viterbo Viterbo self-assigned this Oct 12, 2023
@Viterbo Viterbo linked a pull request Oct 13, 2023 that will close this issue
refactor WalletConnectAuth using signCustomTransaction() #637
Merged
10 tasks
@Viterbo Viterbo mentioned this issue Oct 13, 2023
Merged
10 tasks
@Viterbo Viterbo closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor WalletConnectAuth using signCustomTransaction() telosnetwork/telos-wallet
1 participant
@Viterbo