Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multi-root @config linking #15001

Open
wants to merge 11 commits into
base: next
Choose a base branch
from

Commits on Nov 14, 2024

  1. improve deterministic sorting when dumping files

    1. Sort by depth first
    2. Sort by alphabetical folders
    3. Prefer files starting with `index`
    4. Sort alphabetically
    
    Before this change, when comparing two files, if they both started with
    `index`, then the sort was non-deterministic.
    RobinMalfait committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    23919f5 View commit details
    Browse the repository at this point in the history
  2. find config file from stylesheet while crawling up

    This ensures that the closest config file for a stylesheet is linked. We
    also write some information to the user so they can verify that the
    paths are correct (and adjust if necessary).
    RobinMalfait committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b23203d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. add failing tests

    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    29eccfe View commit details
    Browse the repository at this point in the history
  2. improve output messages

    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0fd30fc View commit details
    Browse the repository at this point in the history
  3. always work with absolute paths

    This ensures that once we figure out the absolute path, that we don't
    accidentally resolve it against the wrong `base`.
    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    315dff6 View commit details
    Browse the repository at this point in the history
  4. print PostCSS config path in similar fashion

    Other logs print files with backticks relative to the process. This
    makes it consistent.
    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f345db6 View commit details
    Browse the repository at this point in the history
  5. use existing highlight function

    Otherwise all file paths are white just like all the other text.
    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ad7da20 View commit details
    Browse the repository at this point in the history
  6. tmp: run Windows tests

    We are dealing with some paths...
    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c005e24 View commit details
    Browse the repository at this point in the history
  7. Revert "tmp: run Windows tests"

    This reverts commit c005e24.
    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a29445d View commit details
    Browse the repository at this point in the history
  8. update changelog

    RobinMalfait committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1a630c7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e872eb8 View commit details
    Browse the repository at this point in the history