Improve multi-root @config linking
#15001
Draft
+274
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/improve-multi-root-without-at-config
branch
from
7dc9df5
to
9679088
Compare
1. Sort by depth first 2. Sort by alphabetical folders 3. Prefer files starting with `index` 4. Sort alphabetically Before this change, when comparing two files, if they both started with `index`, then the sort was non-deterministic.
This ensures that the closest config file for a stylesheet is linked. We also write some information to the user so they can verify that the paths are correct (and adjust if necessary).
We are dealing with some paths...
RobinMalfait
force-pushed
the
fix/improve-multi-root-without-at-config
branch
from
9679088
to
958c58e
Compare
RobinMalfait
force-pushed
the
fix/improve-multi-root-without-at-config
branch
from
6ffd59a
to
5e447be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the codemod when dealing with multi-root CSS files.
Test plan:
Running this on Tailwind UI's codebase it looks like this: