Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other platforms to run tests on #502

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add other platforms to run tests on #502

merged 2 commits into from
Feb 21, 2024

Conversation

sumpfork
Copy link
Owner

@sumpfork sumpfork commented Feb 21, 2024

Add other platforms to test on in github actions as we've had trouble with differing behaviours.

@sumpfork sumpfork self-assigned this Feb 21, 2024
@sumpfork sumpfork requested a review from nickv2002 February 21, 2024 01:17
@sumpfork sumpfork mentioned this pull request Feb 21, 2024
@@ -1,5 +1,5 @@
[tox]
envlist = py38
envlist = py39
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated (and unused in CI) change, just matching python version required elsewhere.

Copy link
Collaborator

@nickv2002 nickv2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pretty neat that GitLab supports all these OS versions.

@sumpfork sumpfork merged commit 9e0234c into master Feb 21, 2024
7 checks passed
@sumpfork sumpfork deleted the test_other_platforms branch February 21, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants