Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Dockerfile #501

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Initial Dockerfile #501

merged 4 commits into from
Feb 21, 2024

Conversation

nickv2002
Copy link
Collaborator

@nickv2002 nickv2002 commented Feb 21, 2024

This adds a dockerfile that can be built more easily and platform-agnostic than the Python virtual env and some instructions for how to run that via CLI. This was based on my own suggested in another PR.

@sumpfork LMK if you have questions, otherwise go ahead and merge this.

Potential next steps:

  1. Build the dockerfile via GitHub Workflows and host a pre-built one in this project
  2. Add additional dockerfile-based testing steps to make testing easier
  3. Add instructions to bind mount the project dir to use docker in development iteration loop

@nickv2002 nickv2002 changed the title Dockerfile Initial Dockerfile Feb 21, 2024
@nickv2002 nickv2002 marked this pull request as ready for review February 21, 2024 00:56
README.md Outdated Show resolved Hide resolved
@sumpfork
Copy link
Owner

This is fine to add, too, but I was thinking of something much simpler to start: #502.

@nickv2002 nickv2002 merged commit a869767 into master Feb 21, 2024
7 checks passed
@nickv2002 nickv2002 deleted the dockerfile branch February 21, 2024 18:40
@nickv2002 nickv2002 mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants