-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide Rewrite #34
Guide Rewrite #34
Conversation
I think that instead of 3 separate files, using If we choose to publish this guide to Spring Academy, we could set the variable
@Buzzardo what do you think about this use of a conditional? EDIT: The command above will not work correctly when using include statements. An prerequisite step is to use asciidoc reducer. |
Converted to draft until I come up with a better solution to importing some common components from the getting started macros GitHub repository. Thanks for the feedback @mbhave! |
…ted-macros repository
I added a new file to the getting-started-macros repository that is intended to be a common section at the end of every guide. |
The 3 files in this PR can be checked into the common macro project at a later date.
Before those files are checked into the macro project and used as a template for all guides to follow, I'd like to verify that the process to convert content to Spring Academy (reducer, downdoc) is successful. This requires a GitHub action to execute, which should be performed on a non-forked repo. |
This is a rewrite of the guide with many changes. In addition to content changes, structural changes were made to the guide as a potential template for future guide updates to follow.
Addresses issues #33, #32, #31, #29, #28.
Several changes were made to promote correctness, make for a better user experience, and allow the option to dual publish to Spring Academy in the future.
TheREADME.adoc
has no text content, but instead links to 3 separate files. This allows spring.io/guides to publish the guide with the full context, including Spring Initializr, while allowing Spring Academy to only be concerned with the guide specific content, located incontent.adoc
. There should be no change for how users view the guide on spring.io.README.adoc
added an additional conditional section that can be set if rendering for Spring Academy to exclude certain sections.initial
andcomplete
folders were removed in favor of keeping only the solution in the root project directory. This should simplify the user experience by providing fewer places to look for code and create an easier experience when importing the project to an IDE. The user can still follow along with a blank project by starting with Spring Initializr. This format of keeping the code in the root directory makes it possible to easily load the project to Spring Academy as well.This web application is 100% pure Java...
comes from a common file. Second, some teachings were incorrect. For example, in the popular rest-service guide, we advise the user that@ComponentScan
will check thecom/example
package, but that information is not correct. It will in fact check thecom/example/restservice
package in this particular guide. Third, the commands to package the application as a jar file were not correct. The problem is persistent to all guides as described here.web.xml
and WAR files, were also removed. This was done when removing links to the common GitHub macro repository in favor of static text.Build an executable JAR
section was renamed toBuilding the Application
and text was added for using Cloud Native Buildpacks and Native Image compilation.