Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not use awaitility #29

Closed
glelouet opened this issue Feb 15, 2024 · 3 comments
Closed

does not use awaitility #29

glelouet opened this issue Feb 15, 2024 · 3 comments
Assignees

Comments

@glelouet
Copy link

The guide requests to add the awaitility dependency, though there is not test present, that dependency has test scope.

Proposal : oneOf

  1. add test that require that library
  2. remove that dependancy.
@ttaolu
Copy link

ttaolu commented Mar 22, 2024

How to test use awaitility ?

@naragon
Copy link

naragon commented Apr 19, 2024

If you look in the src/test under the completed project, you'll see the tests that use the Awaitility library. The guide itself should be updated though to include that in the instructions.

@robertmcnees robertmcnees self-assigned this May 22, 2024
@robertmcnees
Copy link
Contributor

Hi @glelouet. Thanks for the issue. Since 3.2, awaitility is now a dependency that Boot manages. I cleaned up the guide with PR #34 that should make things more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants