Add fix for HASP data sometimes creating a product with no good pixels #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making the section that calculated the first and last good wavelengths throw an exception. Catch this case. Since this doesn't happen for Ullyses data, we don't need to catch this case in the Ullyses wrapper like we do in HASP
Bug for STIS CCD data where input data maps to beyond the end of the product arrays Issue for some COS data that hasn't been processed with the latest calcos code so doesn't have variance columns in data table - use gcounts instead
Rplesha
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
I tested this code on three targets, using the current "main" branch of ullyses-utils and this branch installed:
- AV456 - Massive star with FUSE, COS/G130M&G160M, STIS/E140H&E230H&E230M
- HD-104237E - T-tauri star in the observed ULLYSES sample with COS/G130M, STIS/G140L&G230L&G430L&G750L
- SZ100 - Custom calibrated T-tauri star in the observed ULLYSES sample with STIS/G230L&G430L&G750L
For all three targets, there were no differences in the data compared to DR6 products. In the file headers, the only difference was in the DATE column and the FITS_SW version (I used a more recent version of v5.1.1 compared to v5.0.4).
@jotaylor you'll still need to approve the request though since I am not an owner. EDIT: Apparently you might not need to approve it. I was given approval powers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the coadd code creates a product with no good pixels (all have effective_exptime = 0.0), the code will throw an exception when trying to calculate the first and last good wavelengths. This sometimes happens for HASP STIS data, but not for Ullyses data as the preprocessing of STIS data takes care of this. To fix, the first and last good wavelengths are set to None if there are no good pixels. The HASP wrapper code detects this and doesn't try to make a product in such a case, but I didn't add a handler to the Ullyses wrapper since the case doesn't occur (and perhaps throwing an exception is preferred to raise visibility to this case).