Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with output data overflowing output array #60

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

stscirij
Copy link
Collaborator

This is the same fix that was applied to STIS CCD data in #47. I didn't expect it to be a problem for COS data, but we have seen some NUV data overflow the output array and this small change fixes the problem

@stscirij
Copy link
Collaborator Author

This will result in one extra element at the long-wavelength end of each of the arrays, but all the other elements should be identical to those generated without this fix

@jotaylor
Copy link
Collaborator

jotaylor commented Sep 29, 2023

@stscirij Curiously, I obtained identical results when I compared products from this branch with main. I used target AV-14 which has G185M data. Is that expected? I was expecting the data arrays to be one element longer.

@jotaylor
Copy link
Collaborator

Oops, disregard my previous comment. I don't think I properly checked out this branch when making the comparison products. Now I see the addition of another element in the data arrays. Otherwise the spectra appear identical.

@jotaylor jotaylor merged commit e625efa into spacetelescope:main Sep 29, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants