Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: TPF support #82

Merged
merged 15 commits into from
Apr 5, 2024
Merged

Feature: TPF support #82

merged 15 commits into from
Apr 5, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 29, 2024

bmorris3 and others added 3 commits January 23, 2024 13:39
* adding Kepler TPF parser
* adding TPF translator to the parser
* adding kepler and tess specific TPF translators
* remote data test via searchtargetpixelfile

---------

Co-authored-by: Kyle Conroy <[email protected]>
* TPF cube viewer
* set correct attributes for axes in cube viewer
* enable mouseover display for cube viewer
* fix tracebacks when unloading all data from viewer
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: Patch coverage is 85.60000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 93.01%. Comparing base (7b78df5) to head (70589a7).
Report is 6 commits behind head on main.

❗ Current head 70589a7 differs from pull request most recent head 629e1b4. Consider uploading reports for the commit 629e1b4 to get more accurate results

Files Patch % Lines
lcviz/utils.py 84.96% 23 Missing ⚠️
lcviz/plugins/coords_info/coords_info.py 52.63% 9 Missing ⚠️
lcviz/viewers.py 96.36% 2 Missing ⚠️
lcviz/parsers.py 95.23% 1 Missing ⚠️
lcviz/plugins/ephemeris/ephemeris.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   93.92%   93.01%   -0.92%     
==========================================
  Files          37       35       -2     
  Lines        1598     1746     +148     
==========================================
+ Hits         1501     1624     +123     
- Misses         97      122      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry added the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Mar 11, 2024
* enable clone viewer tool in image viewer

(currently results in traceback, as shown in regression test)

* include cube viewer in viewer creator

* generalize clone viewer logic to work for multliple viewer types

and to also adopt layer plot options

* remove cube from viewer creator when no cube data remaining
@kecnry kecnry removed the waiting-on-jdaviz-release PR requires a release from jdaviz before updating the pin label Apr 5, 2024
@kecnry kecnry marked this pull request as ready for review April 5, 2024 19:30
@kecnry kecnry requested a review from bmorris3 April 5, 2024 19:31
@kecnry
Copy link
Member Author

kecnry commented Apr 5, 2024

Each significant incremental step has already been approved, so I'm merging without reviews.

@kecnry kecnry merged commit 6982333 into main Apr 5, 2024
9 checks passed
@kecnry kecnry deleted the feature-tpf branch April 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants