enable clone viewer for image/TPF viewer #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
commented
Mar 27, 2024
| @@ -24,13 +29,18 @@ def _rebuild_available_viewers(self, *args): | |||
| if self.app._jdaviz_helper is not None: | |||
| phase_viewers = [{'name': f'lcviz-phase-viewer:{e}', 'label': f'flux-vs-phase:{e}'} | |||
| for e in self.app._jdaviz_helper.plugins['Ephemeris'].component.choices] # noqa | |||
| if self.app._jdaviz_helper._has_cube_data: | |||
There was a problem hiding this comment.
right now this enables creating an "image" viewer if there is any cube-like data in the app. In the future, we may want to change this to allow image-like data, but that is not yet supported at the parser level.
kecnry
force-pushed
the
tpf-clone-viewer
branch
from
dff2bb2
to
97e6f20
Compare
kecnry
commented
Mar 27, 2024
Comment on lines
-256
to
-282
| def clone_viewer(self): | ||
| name = self.jdaviz_helper._get_clone_viewer_reference(self.reference) | ||
|
|
||
| self.jdaviz_app._on_new_viewer(NewViewerMessage(self.__class__, | ||
| data=None, | ||
| sender=self.jdaviz_app), | ||
| vid=name, name=name) | ||
|
|
||
| this_viewer_item = self.jdaviz_app._get_viewer_item(self.reference) | ||
| this_state = self.state.as_dict() | ||
| for data in self.jdaviz_app.data_collection: | ||
| data_id = self.jdaviz_app._data_id_from_label(data.label) | ||
| visible = this_viewer_item['selected_data_items'].get(data_id, 'hidden') | ||
| self.jdaviz_app.set_data_visibility(name, data.label, visible == 'visible') | ||
| # TODO: don't revert color when adding same data to a new viewer | ||
| # (same happens when creating a phase-viewer from ephemeris plugin) | ||
|
|
||
| new_viewer = self.jdaviz_app.get_viewer(name) | ||
| if hasattr(self, 'ephemeris_component'): | ||
| new_viewer._ephemeris_component = self._ephemeris_component | ||
| for k, v in this_state.items(): | ||
| if k in ('layers',): | ||
| continue | ||
| setattr(new_viewer.state, k, v) | ||
|
|
||
| return new_viewer.user_api | ||
|
|
There was a problem hiding this comment.
this was duplicated logic that was somehow introduced when refactoring to use the mixin for clone viewer support
(currently results in traceback, as shown in regression test)
and to also adopt layer plot options
kecnry
force-pushed
the
tpf-clone-viewer
branch
from
5e74ebe
to
48c311c
Compare
bmorris3
approved these changes
Apr 4, 2024
yeeeeaaah, I think its just supposed to generically represent "graph" or "plot". I agree it isn't ideal, but that is defined in jdaviz and adopted here 🤷♂️ |
kecnry
added a commit
that referenced
this pull request
Apr 5, 2024
* Adding TPF translator and parser (#75) * TPF viewer (#81) * make use of upstream refactor to override indices in lcviz (#83) * fix creating phase-viewer when TPF is loaded (#86) * Time Selector (adapted version of cubeviz's slice) plugin (#85) * enable clone viewer for image/TPF viewer (#101) --------- Co-authored-by: Brett M. Morris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the clone viewer functionality for the TPF/image viewers as well as the ability to create a new blank cube viewer (so long as cube-like data exists in the data collection), and in doing so also:
NOTE: this should be tested with jdaviz main (3.9) and is expected to fail tests on CI until rebased on top of #68. Tests do pass locally for me and we'll ensure they pass before merging #82 into main.
Screen.Recording.2024-03-27.at.3.10.44.PM.mov