Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supported Python version #40

Closed
wants to merge 1 commit into from
Closed

Fix supported Python version #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .idea/check_done.iml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

192 changes: 39 additions & 153 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 9 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ repository = "https://github.com/siisurit/check_done.git"
documentation = "https://github.com/siisurit/check_done/blob/main/README.md"
keywords = ["check", "closed", "done", "done done", "finished", "issue", "task", "validate"]
classifiers = [
"Development Status :: 4 - Beta",
"Development Status :: 4 - Beta",
Copy link
Collaborator

@mcsken mcsken Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original indentation was correct, should be reverted.

"Environment :: Console",
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
Expand All @@ -37,18 +37,14 @@ packages = [
]

[tool.poetry.dependencies]
python = ">=3.10, <3.14"
pygments = "^2"
chardet = "^5"
rich = ">=9, <14"
gitpython = "^3"
python = ">=3.11, <3.14"

Copy link
Collaborator

@mcsken mcsken Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary empty space, should be removed.

pyyaml = "^6.0.2"
python-dotenv = "^1.0.1"
pytest-mock = "^3.14.0"
pydantic = "^2.10.2"
pyjwt = "^2.9.0"
requests-mock = "^1.12.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requests-mock should have been removed from the main dependencies when it was moved to dev dependencies.

pytest-order = "^1.3.0"
requests = "^2.32.3"

[tool.poetry.dev-dependencies]
coverage = "^7"
Expand All @@ -65,6 +61,11 @@ check_done = "check_done.command:main"
"Changelog" = "https://github.com/siisurit/check_done/blob/main/CHANGELOG.md"
"Issue Tracker" = "https://github.com/siisurit/check_done/issues"

[tool.poetry.group.dev.dependencies]
cryptography = "^44.0.0"
requests-mock = "^1.12.1"
python-dotenv = "^1.0.1"

Comment on lines +64 to +68
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage, pytest, pytest-cov, pre-commit and ruff should have been migrated from the old-style dev dependencies group to the new one here, and the old dev dependencies section should have been as a result removed.

[tool.ruff]
exclude = [
".eggs",
Expand Down
5 changes: 5 additions & 0 deletions tests/test_conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Copyright (C) 2024 by Siisurit e.U., Austria.
# All rights reserved. Distributed under the MIT License.

from dotenv import load_dotenv
load_dotenv()
Comment on lines +4 to +5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why did you create a new test file that doesn't align with any module and that does nothing but load the environment variables?

This was not part of the requirements.

You mentioned in the PR "Ensure everything works by testing the environment", but nothing is being actually tested here. And no environment-variable-dependent test is needed to complete the requirements of this issue.