Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doc path for moved repository #2621

Closed
wants to merge 1 commit into from
Closed

fix: doc path for moved repository #2621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/Shopware/Components/ReflectionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function createInstanceFromNamedArguments($className, $arguments, $secure
$folders = Shopware()->Container()->getParameter('shopware.plugin_directories');

$folders[] = Shopware()->DocPath('engine_Shopware');
$folders[] = Shopware()->DocPath('vendor_shopware_shopware');
$folders[] = Shopware()->DocPath('vendor_shopware5_shopware');
Copy link
Contributor

@shyim shyim Nov 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the name computed by the composer package name, and that is still shopware/shopware 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyim is right. @jschwalmi with your change, the path would look like this: /home/mt/www/5.7/vendor/shopware5/shopware/, but that path does not exist.

Could you explain, how the problem could be reproduced?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitelg @shyim
I discovered this problem because it was reported that the product stream with Peudo prices no longer worked. All products were displayed in the stream and not only the discounted products.
In the \Shopware_Controllers_Backend_ProductStream::loadPreviewAction the conditions could not be unserialized. vendor/shopware5/shopware/engine/Shopware/Controllers/Backend/ProductStream.php:99.
I think all product streams that have a condition are affected by this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you installed Shopware? 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyim I install Shopware over composer. Do you think that this is not the case in a ZIP installation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

composer create-project shopware/composer-project:@dev test
cd test
ls -la vendor/shopware/shopware

seems fine for me 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it could work


foreach ($folders as $folder) {
$directories[] = substr($folder, \strlen($docPath));
Expand Down