fix: doc path for moved repository #2621
Conversation
|
|
|
|
hey @jschwalmi thanks for your contribution! Good catch indeed 😁 👍 Please make sure, that you commit the changes with your GitHub user and sign the CLA with this user 🙂 The commit message should look like described here: https://github.com/shopware5/shopware/wiki/Contribute#commit-message |
| @@ -63,7 +63,7 @@ public function createInstanceFromNamedArguments($className, $arguments, $secure | |||
| $folders = Shopware()->Container()->getParameter('shopware.plugin_directories'); | |||
|
|
|||
| $folders[] = Shopware()->DocPath('engine_Shopware'); | |||
| $folders[] = Shopware()->DocPath('vendor_shopware_shopware'); | |||
| $folders[] = Shopware()->DocPath('vendor_shopware5_shopware'); | |||
There was a problem hiding this comment.
isn't the name computed by the composer package name, and that is still shopware/shopware 🤔
There was a problem hiding this comment.
@shyim is right. @jschwalmi with your change, the path would look like this: /home/mt/www/5.7/vendor/shopware5/shopware/, but that path does not exist.
Could you explain, how the problem could be reproduced?
There was a problem hiding this comment.
@mitelg @shyim
I discovered this problem because it was reported that the product stream with Peudo prices no longer worked. All products were displayed in the stream and not only the discounted products.
In the \Shopware_Controllers_Backend_ProductStream::loadPreviewAction the conditions could not be unserialized. vendor/shopware5/shopware/engine/Shopware/Controllers/Backend/ProductStream.php:99.
I think all product streams that have a condition are affected by this.
There was a problem hiding this comment.
How did you installed Shopware? 🤔
There was a problem hiding this comment.
@shyim I install Shopware over composer. Do you think that this is not the case in a ZIP installation?
There was a problem hiding this comment.
composer create-project shopware/composer-project:@dev test
cd test
ls -la vendor/shopware/shopwareseems fine for me 🤔
| @@ -63,7 +63,7 @@ public function createInstanceFromNamedArguments($className, $arguments, $secure | |||
| $folders = Shopware()->Container()->getParameter('shopware.plugin_directories'); | |||
|
|
|||
| $folders[] = Shopware()->DocPath('engine_Shopware'); | |||
| $folders[] = Shopware()->DocPath('vendor_shopware_shopware'); | |||
| $folders[] = Shopware()->DocPath('vendor_shopware5_shopware'); | |||
There was a problem hiding this comment.
@shyim is right. @jschwalmi with your change, the path would look like this: /home/mt/www/5.7/vendor/shopware5/shopware/, but that path does not exist.
Could you explain, how the problem could be reproduced?
|
hey @jschwalmi what is the status here? 😊 |
The comment from @shyim is fine for me :) |
|
alright, then I will close your PR 🙂 👍 |
Wrong DocPath means that the path or class cannot be downloaded.
