fix: limit order never keep stale values for buy asset market price #8456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Buy asset market data price looks like it's a purely derived value as a product of the input buy amount and sell amount, however, it is derived from the quote buy and sell amounts.
A quote however, is RTK query data, and stale RTK query data will stil be present when:
This was producing odd bugs where failures in getting a CoW quote (i.e inputting too low of am amount) would return the previous stale quote, however, the previous quote was for an entirely different asset, and possibly a different precision, which will lead to amounts being off.
Fixed by zero'ing amounts out when fetching/errored.
Issue (if applicable)
closes #8414
Risk
Low to none
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/7ef95c99-ae34-4902-ac15-6302d26ef7ab
https://jam.dev/c/d9e4e20e-6239-43d4-afa7-4fbaab9336b4