Skip to content

Commit

Permalink
fix: limit order never keep stale values for buy asset market price (#…
Browse files Browse the repository at this point in the history
…8456)

fix: limit order never keep stale values for market price
  • Loading branch information
gomesalexandre authored Jan 6, 2025
1 parent 95216c7 commit ef9ae6c
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ export const LimitOrderInput = ({
} = useQuoteLimitOrderQuery(limitOrderQuoteParams)

const marketPriceBuyAsset = useMemo(() => {
// Ensure we zero out the price if there is an error, and when we are fetching, as `quoteResponse` will be stale data in both cases
if (isLimitOrderQuoteFetching || quoteResponseError) return '0'
// RTK query returns stale data when `skipToken` is used, so we need to handle that case here.
if (!quoteResponse || limitOrderQuoteParams === skipToken) return '0'

Expand All @@ -227,7 +229,14 @@ export const LimitOrderInput = ({
sellAsset,
buyAsset,
})
}, [quoteResponse, limitOrderQuoteParams, sellAsset, buyAsset])
}, [
isLimitOrderQuoteFetching,
quoteResponseError,
quoteResponse,
limitOrderQuoteParams,
sellAsset,
buyAsset,
])

// Update the limit price when the market price changes.
useEffect(() => {
Expand Down

0 comments on commit ef9ae6c

Please sign in to comment.