Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: thorchain LP unsafe high-slippage deposits flow #6600

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Mar 28, 2024

Description

Does what it says on the box - same as what we have in lending, savers, and by extension swapper (for unsafe minimums only currently, not high slippage)

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6578

Risk

High Risk PRs Require 2 approvals

Low to none

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

  • Try a relatively high amount deposit of USDT on AVAX e.g something higher than ~10,000 USDT seems to consistently be high-slippage
  • Ensure the high-slippage "I understand" flow is displayed and works

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Screenshot 2024-03-28 at 13 20 03 Screenshot 2024-03-28 at 13 20 10

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gomesalexandre and the rest of your teammates on Graphite Graphite

@gomesalexandre gomesalexandre marked this pull request as ready for review March 28, 2024 12:24
@gomesalexandre gomesalexandre requested a review from a team as a code owner March 28, 2024 12:24
@gomesalexandre gomesalexandre enabled auto-merge (squash) March 29, 2024 08:21
@gomesalexandre gomesalexandre merged commit ebc1c99 into develop Mar 29, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the feat_thorchain_lp_unsafe_deposits branch March 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dangerous deposit confirmation to LP
2 participants