-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent unsafe THOR flow #6605
Comments
@twblack88 - please do the things |
Spiked on this with @0xApotheosis https://www.figma.com/file/ZK7L1l38Kzc4SlKekbPnm0/Modals?type=design&node-id=1%3A250&mode=design&t=2Q6UeUWcj21JCvIm-1 We're gonna flesh out the states, what we expect, and what should happen from there so we have standardization and we also unblock #6577 as a result. |
Follow on for @gomesalexandre notes For ENG (@0xApotheosis monday):
|
Overview
Currently, the flow for "depositing/withdrawing" (i.e withdrawing from savers vault, borrowing into lending, adding liquidity in LP, or swapping) has some notion of an unsafe deposit, which is very similar, though slightly different per domain, and with rough edges:
There are a few issues with this:
References and additional details
#6600 (comment) initially raised here
Acceptance Criteria
Product
Engineering - TBD after we refine the flow
Nice to have:
isDisabled
or<RenderIf />
HOC of sorts) so that consumers are now only concerned about consuming this component, without duplicating the unsafe ack logicNeed By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: