chore: add validation for quotes with incorrect sell amount #6241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents a quote being marked as valid (and therefore executable) when the sell amount isn't exactly the same as the sell amount the user inputted.
Pull Request Type
Issue (if applicable)
closes #5723 specifically point
create sanity check that we never ask a user to sign a transaction that is larger than what a user input
Risk
Low risk as this prevents invalid trades. This check failing or being incorrectly implemented could have 2 possible outcomes
LiFi trades specifically, though theoretically any protocol used in trades
Testing
Check trades are working as normal.
Engineering
Worth monkey patching to ensure a quote with mismatching sell amount results in a generic quote error.
Operations
Screenshots (if applicable)