chore: add validation for quotes with incorrect sell amount (#6241)

shapeshift · Feb 19, 2024 · 99509e1 · 99509e1
1 parent f8f876b
commit 99509e1
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/src/components/MultiHopTrade/components/TradeInput/getQuoteErrorTranslation.ts b/src/components/MultiHopTrade/components/TradeInput/getQuoteErrorTranslation.ts
@@ -48,6 +48,7 @@ export const getQuoteErrorTranslation = (
       case SwapperTradeQuoteError.InternalError:
       case TradeQuoteValidationError.QueryFailed:
       case SwapperTradeQuoteError.QueryFailed:
+      case TradeQuoteValidationError.QuoteSellAmountInvalid:
         return 'trade.errors.quoteError'
       default:
         assertUnreachable(error)

diff --git a/src/state/apis/swapper/helpers/validateTradeQuote.ts b/src/state/apis/swapper/helpers/validateTradeQuote.ts
@@ -42,6 +42,7 @@ export const validateTradeQuote = async (
     isTradingActiveOnSellPool,
     isTradingActiveOnBuyPool,
     sendAddress,
+    inputSellAmountCryptoBaseUnit,
   }: {
     swapperName: SwapperName
     quote: TradeQuote | undefined
@@ -51,6 +52,7 @@ export const validateTradeQuote = async (
     // TODO(gomes): this should most likely live in the quote alongside the receiveAddress,
     // summoning @woodenfurniture WRT implications of that, this works for now
     sendAddress: string | undefined
+    inputSellAmountCryptoBaseUnit: string
   },
 ): Promise<{
   errors: ErrorWithMeta<TradeQuoteError>[]
@@ -252,6 +254,10 @@ export const validateTradeQuote = async (
     return false
   })()
 
+  // ensure the trade is not selling an amount higher than the user input
+  const invalidQuoteSellAmount =
+    inputSellAmountCryptoBaseUnit !== firstHop.sellAmountIncludingProtocolFeesCryptoBaseUnit
+
   return {
     errors: [
       !!disableSmartContractSwap && {
@@ -300,6 +306,7 @@ export const validateTradeQuote = async (
         },
       },
       feesExceedsSellAmount && { error: TradeQuoteValidationError.SellAmountBelowTradeFee },
+      invalidQuoteSellAmount && { error: TradeQuoteValidationError.QuoteSellAmountInvalid },
 
       ...insufficientBalanceForProtocolFeesErrors,
     ].filter(isTruthy),

diff --git a/src/state/apis/swapper/swapperApi.ts b/src/state/apis/swapper/swapperApi.ts
@@ -36,8 +36,15 @@ export const swapperApi = createApi({
     getTradeQuote: build.query<Record<string, ApiQuote>, TradeQuoteRequest>({
       queryFn: async (tradeQuoteInput: TradeQuoteRequest, { dispatch, getState }) => {
         const state = getState() as ReduxState
-        const { swapperName, sendAddress, receiveAddress, sellAsset, buyAsset, affiliateBps } =
-          tradeQuoteInput
+        const {
+          swapperName,
+          sendAddress,
+          receiveAddress,
+          sellAsset,
+          buyAsset,
+          affiliateBps,
+          sellAmountIncludingProtocolFeesCryptoBaseUnit,
+        } = tradeQuoteInput
 
         const isCrossAccountTrade = sendAddress !== receiveAddress
         const featureFlags: FeatureFlags = selectFeatureFlags(state)
@@ -158,6 +165,7 @@ export const swapperApi = createApi({
               isTradingActiveOnSellPool,
               isTradingActiveOnBuyPool,
               sendAddress,
+              inputSellAmountCryptoBaseUnit: sellAmountIncludingProtocolFeesCryptoBaseUnit,
             })
             return {
               id: quoteSource,

diff --git a/src/state/apis/swapper/types.ts b/src/state/apis/swapper/types.ts
@@ -35,6 +35,7 @@ export enum TradeQuoteValidationError {
   InsufficientSecondHopFeeAssetBalance = 'InsufficientSecondHopFeeAssetBalance',
   InsufficientFundsForProtocolFee = 'InsufficientFundsForProtocolFee',
   IntermediaryAssetNotNotSupportedByWallet = 'IntermediaryAssetNotNotSupportedByWallet',
+  QuoteSellAmountInvalid = 'QuoteSellAmountInvalid',
   QueryFailed = 'QueryFailed',
   UnknownError = 'UnknownError',
 }