feat: enable lifi cross-account trades #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xApotheosis
commented
Dec 12, 2023
0xApotheosis
commented
Dec 12, 2023
gomesalexandre
approved these changes
Dec 12, 2023
gomesalexandre
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
On @woodenfurniture's recommendation, managed to test (after many many tries, fees estimation are still turbo long and borked) with Avalanche as Gnosis fees estimation is all kinds of slow and borked atm, got lucky with it when testing 1inch cross-account but seems borked now.
Account 0 -> 1
Note, while not strictly related to this PR, found some interesting discrepancy in the underlying tool being used by the Li.Fi routing vs. the one announced (cc @woodenfurniture):
Account 1 -> 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cross-account trading to LifI.
Cross-account LiFi transactions created from this branch:
Pull Request Type
Issue (if applicable)
Relates to #4966
Risk
Medium. It's a small change, but as always, touching account selection is risky as mistakes can mean lost funds.
Testing
Confirm that Li.Fi quotes now show up when trading between accounts, and that they and sent and received from the correct accounts when executed.
Engineering
Sanity check logic.
Operations
☝️
Screenshots (if applicable)