-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to fetch rates for all swapper protocols when trading between acounts #4966
Comments
This may be related to certain swappers not support a different final address for the swap, but this is not apparent to the user and we should give them better messaging about the issue. |
This is not a bug, but rather a lack of functionality.
I'll also investigate doing the same for LiFi, though @woodenfurniture might have some info on why this isn't already turned on there. |
Also got LiFi working for cross-account trades in #5835. |
Overview
When using swapper and trading between Account 0 and 1, a user in unable to fetch rates.
References and additional details
When the Thornode went down this was much more apparent as the only rates being fetched for swaps between different accounts currently are thor and osmo rates.
Acceptance Criteria
Trading between different accounts in swapper (account 0 > account 1) provides accurate rates for all available swapper protocols.
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response
The text was updated successfully, but these errors were encountered: