Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: foxy claim handle 0-amount delegations #5489

Merged
merged 5 commits into from
Oct 18, 2023
Merged

feat: foxy claim handle 0-amount delegations #5489

merged 5 commits into from
Oct 18, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 18, 2023 •
edited
Loading

Description

Does what it says on the box - ensures we don't consider 0-amount undelegations as valid claims, see prod:

Screenshot 2023-10-18 at 15 52 59 Screenshot 2023-10-18 at 15 53 35 Screenshot 2023-10-18 at 15 53 44 image

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

  • We might not be allowing legit claims

Testing

  • Test release against prod, ensuring the claim button is disabled in case of 0 amount to claim. Deployed to gome for testing against prod, since localhost is rugged with FOXy

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

No withdrawal to claim

image

Withdraw to claim

image

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre mentioned this pull request Oct 18, 2023
Merged
3 tasks
@gomesalexandre gomesalexandre marked this pull request as ready for review October 18, 2023 14:51
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 18, 2023 14:51
0xApotheosis
0xApotheosis approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FOXy claim flow worked as expected on gome.

@0xApotheosis 0xApotheosis force-pushed the feat_foxy_pending_state branch from 4d53552 to 3d4347f Compare October 18, 2023 22:20
Base automatically changed from feat_foxy_pending_state to develop October 18, 2023 22:26
@0xApotheosis 0xApotheosis enabled auto-merge (squash) October 18, 2023 22:34
@0xApotheosis 0xApotheosis merged commit b7c41f5 into develop Oct 18, 2023
6 checks passed
@0xApotheosis 0xApotheosis deleted the feat_foxy_0_claims branch October 18, 2023 22:39
@0xApotheosis 0xApotheosis mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @0xApotheosis