Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: foxy canClaimWithdraw loading state #5488

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 18, 2023

Description

Ensures the "Claim Now" as well as the "Claim" button are in a loading state while canClaimWithdraw is loading

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

None, this only adds a loading state

Testing

  • Ensure FOXy "Claim" and "Claim Now" buttons aren't clickable with a withdraw in "Pending" loading state. Note, since FOXy doesn't work locally, this has been deployed and tested in gome.

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image image

Copy link
Contributor Author

gomesalexandre commented Oct 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review October 18, 2023 10:45
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 18, 2023 10:45
@0xApotheosis 0xApotheosis force-pushed the feat_foxy_pending_state branch from 4d53552 to 3d4347f Compare October 18, 2023 22:20
@0xApotheosis 0xApotheosis enabled auto-merge (squash) October 18, 2023 22:20
@0xApotheosis 0xApotheosis merged commit 5539558 into develop Oct 18, 2023
6 checks passed
@0xApotheosis 0xApotheosis deleted the feat_foxy_pending_state branch October 18, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants