Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: defi only render current step if active #5476

Merged
merged 10 commits into from
Oct 18, 2023
Merged

perf: defi only render current step if active #5476

merged 10 commits into from
Oct 18, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 17, 2023 •
edited
Loading

Description

Technically a perf PR, but should also solve a bunch of future DeFi modals bugs down the line, by not always rendering all steps.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Relates to #5445

Risk

  • DeFi modals may be broken, test accordingly

Testing

  • DeFi modals are happy, from input to status step. Was only able to test up to the confirm step, which should bring the same guarantees

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image image

This was referenced Oct 17, 2023
Merged
Merged
Merged
Merged
@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review October 17, 2023 13:26
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 17, 2023 13:26
@0xApotheosis 0xApotheosis self-assigned this Oct 17, 2023
0xApotheosis
0xApotheosis approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defi stepping still looking good 👌

Base automatically changed from feat_perf_lazy_4 to develop October 18, 2023 22:43
@0xApotheosis 0xApotheosis merged commit 7a68ec4 into develop Oct 18, 2023
1 check passed
@0xApotheosis 0xApotheosis deleted the feat_lazy_defi_1 branch October 18, 2023 22:46
@0xApotheosis 0xApotheosis mentioned this pull request Oct 18, 2023
Merged
0xApotheosis added a commit that referenced this pull request Oct 19, 2023
@gomesalexandre @woodenfurniture @0xApotheosis
perf: defi only render current step if active (#5476)
1cb32f9 
* wip: walletprovider type narrowing

* feat: cast KKRestAdapter type

* feat: cast multichain adapter as MetaMaskAdapter

* feat: rm ts-ignore

* fix: infinite dispatch

* feat: rm useless ts-ignore

* wip

* feat: gm, she compiles again

* perf: defi only render current step if active

---------

Co-authored-by: woodenfurniture <[email protected]>
Co-authored-by: Apotheosis <[email protected]>
@0xApotheosis 0xApotheosis mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees

@0xApotheosis 0xApotheosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gomesalexandre @0xApotheosis @woodenfurniture