-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: actually lazy load hdwallet adapter modules #5466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
3 tasks
gomesalexandre
force-pushed
the
feat_perf_lazy_3
branch
from
October 14, 2023 12:29
bce2ef5
to
e69bacd
Compare
gomesalexandre
changed the title
wip: actually load hdwallet adapter modules
wip: actually lazy load hdwallet adapter modules
Oct 14, 2023
gomesalexandre
commented
Oct 14, 2023
gomesalexandre
changed the title
wip: actually lazy load hdwallet adapter modules
feat: actually lazy load hdwallet adapter modules
Oct 15, 2023
gomesalexandre
commented
Oct 15, 2023
gomesalexandre
commented
Oct 15, 2023
gomesalexandre
commented
Oct 15, 2023
gomesalexandre
force-pushed
the
feat_perf_lazy_2
branch
from
October 16, 2023 07:54
4e120d9
to
9c76875
Compare
gomesalexandre
force-pushed
the
feat_perf_lazy_3
branch
from
October 16, 2023 07:54
7b5d4d7
to
2a6e615
Compare
3 tasks
woodenfurniture
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+9000 points for the best pr description ever
smoother than a fresh jar of peanut butter
woodenfurniture
force-pushed
the
feat_perf_lazy_3
branch
from
October 17, 2023 00:25
2a6e615
to
7094513
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yo dawg, we heard you like wallets, so we put some lazy wallet loading in your wallet loading, so you can transact while you transact! 🚀 Welcome to our super-duper PR where we're turning sloth-mode ON to hit you up with the snazziest, laziest import of hdwallet npm packages that you've ever seen.
Why, you ask? Because ain't nobody got time to wait for those hefty hdwallet bundles to load! 😴 By incorporating a luxuriously lazy loading mechanism, we make sure your user experience is smoother than a fresh jar of peanut butter. 🥜✨ Now you can keep your transactions and crypto dealings as swift as a ninja, all while our code does the heavy (or should we say, light?) lifting in the background.
In a nutshell:
Pull Request Type
Issue (if applicable)
Risk
Very high. Test all wallets connection and reconnection, in all states, e.g native wallet import, locked native unlock, MM in locked state, KK wallet import, KK unlock, app refresh, etc...
Test all states and ensure no regression against prod.
Tested with:
Testing
Engineering
Operations
Screenshots (if applicable)