Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: actually lazy load hdwallet adapter modules #5466

Merged
merged 19 commits into from
Oct 17, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 13, 2023

Description

Yo dawg, we heard you like wallets, so we put some lazy wallet loading in your wallet loading, so you can transact while you transact! 🚀 Welcome to our super-duper PR where we're turning sloth-mode ON to hit you up with the snazziest, laziest import of hdwallet npm packages that you've ever seen.

Why, you ask? Because ain't nobody got time to wait for those hefty hdwallet bundles to load! 😴 By incorporating a luxuriously lazy loading mechanism, we make sure your user experience is smoother than a fresh jar of peanut butter. 🥜✨ Now you can keep your transactions and crypto dealings as swift as a ninja, all while our code does the heavy (or should we say, light?) lifting in the background.

In a nutshell:

  • Maximize efficiency 🚀
  • Minimize loading times ⏲️
  • Optimize your chill while we work in the stealth 🐢👤

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Risk

Very high. Test all wallets connection and reconnection, in all states, e.g native wallet import, locked native unlock, MM in locked state, KK wallet import, KK unlock, app refresh, etc...
Test all states and ensure no regression against prod.

Tested with:

Testing

  • See risks - test all wallet states and ensure no regression against prod
  • Ensure wallet/accounts switching is happy and has no regressions against prod

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Copy link
Contributor Author

gomesalexandre commented Oct 13, 2023

@gomesalexandre gomesalexandre changed the title wip: actually load hdwallet adapter modules wip: actually lazy load hdwallet adapter modules Oct 14, 2023
@gomesalexandre gomesalexandre changed the title wip: actually lazy load hdwallet adapter modules feat: actually lazy load hdwallet adapter modules Oct 15, 2023
@gomesalexandre gomesalexandre marked this pull request as ready for review October 15, 2023 17:05
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 15, 2023 17:05
Base automatically changed from feat_perf_lazy_2 to develop October 17, 2023 00:20
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+9000 points for the best pr description ever

smoother than a fresh jar of peanut butter

@woodenfurniture woodenfurniture merged commit c06fc5c into develop Oct 17, 2023
3 checks passed
@woodenfurniture woodenfurniture deleted the feat_perf_lazy_3 branch October 17, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants