Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ledger fixes and improvements #5444

Merged
merged 24 commits into from
Oct 18, 2023
Merged

feat: ledger fixes and improvements #5444

merged 24 commits into from
Oct 18, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 11, 2023 •
edited
Loading

Description

This PR:

  • fixes approval step being in an infinite loading state for Ledger (faef83a)
  • fixes ethSignMessage for Ledger (shapeshift/hdwallet@598d5ff)
  • fixes broken ws when using Ledger as a wallet
    • EVM chains - dd72003 fixed by passing xpub through - effectively as a fall-through
    • UTXOs - 824edde fixed by passing xpub through
  • adds a close button to Ledger's chain selection modal (423902b)
  • adds verify buttons for trades (c1398cf)
  • ensures we always compare lowercased version of addresses when verifying on device (db1dda7)
  • fix UTXO trades - ffe4fc7 and ee12739

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

  • Trade approvals - blind signing
image image
  • Ledger ethSignMessage
image
  • UTXO and EVM websockets
image
  • Addresses verification
image
  • UTXO succesful swap

image

@gomesalexandre gomesalexandre mentioned this pull request Oct 11, 2023
Merged
9 tasks
@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Oct 11, 2023
Merged
Merged
@gomesalexandre gomesalexandre changed the title fix: useApprovalTx pass AccountId account as from down to getFees() feat: ledger fixes and improvements Oct 11, 2023
@gomesalexandre gomesalexandre force-pushed the feat_unchained_addresses branch from 4925a7a to 2363630 Compare October 11, 2023 18:53
@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from d24ca84 to 06e57f7 Compare October 11, 2023 18:53
Base automatically changed from feat_unchained_addresses to develop October 11, 2023 19:00
@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from 06e57f7 to 01ffab2 Compare October 11, 2023 19:09
gomesalexandre
gomesalexandre commented Oct 12, 2023
View reviewed changes
.yarnrc.yml Outdated Show resolved Hide resolved
gomesalexandre
gomesalexandre commented Oct 12, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from 0e5aa85 to 9ed938f Compare October 12, 2023 18:03
@gomesalexandre gomesalexandre marked this pull request as ready for review October 12, 2023 19:48
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 12, 2023 19:48
woodenfurniture
woodenfurniture approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some non-blocking comments, otherwise conceptually lgtm

@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from 8c18e71 to 39f02bf Compare October 18, 2023 17:48
@gomesalexandre gomesalexandre enabled auto-merge (squash) October 18, 2023 19:52
@gomesalexandre gomesalexandre merged commit 38c3177 into develop Oct 18, 2023
6 checks passed
@gomesalexandre gomesalexandre deleted the feat_ledger_improvements branch October 18, 2023 19:52
@0xApotheosis 0xApotheosis mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @woodenfurniture